Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies update #15

Merged
merged 4 commits into from
Aug 28, 2024
Merged

Dependencies update #15

merged 4 commits into from
Aug 28, 2024

Conversation

gaumut
Copy link
Contributor

@gaumut gaumut commented Aug 20, 2024

No description provided.

@YuhanLiin
Copy link
Collaborator

You need to update the MSRV to 1.64 to make the tests pass. Also need to fix lint failures. Otherwise everything looks good.

@gaumut
Copy link
Contributor Author

gaumut commented Aug 23, 2024

There is still a lint about the size of LobpcgResult, I don’t know what to make of this.

@YuhanLiin
Copy link
Collaborator

That lint is an non-issue. Just add #[allow(clippy::result_large_err)] to make the lint go away. Also you need to update the MSRV in the CI jobs so they use a newer Rust version.

@YuhanLiin
Copy link
Collaborator

Can you update MSRV to 1.65 for proptest?

@YuhanLiin YuhanLiin merged commit b9a7246 into rust-ml:main Aug 28, 2024
11 of 13 checks passed
@YuhanLiin
Copy link
Collaborator

Thanks for the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants