Simplify download abstractions and start warning about curl usage #4277
+646
−712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rami3l
approved these changes
Apr 4, 2025
rami3l
reviewed
Apr 4, 2025
ChrisDenton
approved these changes
Apr 4, 2025
Why would it? I think we still build the rustup crate, whose features have not changed. |
djc
force-pushed
the
warn-curl
branch
5 times, most recently
from
804d055 to
764a96c
Compare
rami3l
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another step towards #3790. Also in #2626 it was noted that curl is imposing substantial overhead on startup time, even when it is not being used.