-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add release notes for 1.86.0 #139002
Add release notes for 1.86.0 #139002
Conversation
rustbot has assigned @Mark-Simulacrum. Use |
Hi relnotes-interest-group, this issue/PR could use some help in reviewing / cc @alex-semenyuk @jieyouxu @joshtriplett @lcnr @traviscross |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, only style nits
dba7271
to
af7359e
Compare
r? @BoxyUwU since you're running the release I think? |
Co-authored-by: Mark Rousskov <[email protected]> Co-authored-by: alexey semenyuk <[email protected]>
- [The `wasm_c_abi` future compatibility warning is now a hard error.](https://github.com/rust-lang/rust/pull/133951) | ||
Users of `wasm-bindgen` should upgrade to at least version 0.2.89, otherwise compilation will fail. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this note correct and telling the whole story? I am just now noticing that nightly (i.e. ~1.87) is warning about a lint named wasm_c_abi
, which presumably reflects recent PR #138601. Is what's going on that there are two ABI changes and lints which happen to share the same lint name? If so, it might be worth a sentence to clarify the situation for users who use both stable and nightly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This note corresponds to #133951
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems confusing that we turned a FCW Into a hard error and then added new FCWs to the same lint that was previously hard errored
@bors r+ rollup not sure waht to do about the wasm abi lint thing, but these notes have already been included in the PR to the stable branch so are effectively "merged" already. any changes would need to also be backported to the stable branch aiui |
Compatibility Notes | ||
------------------- | ||
- [The `wasm_c_abi` future compatibility warning is now a hard error.](https://github.com/rust-lang/rust/pull/133951) | ||
Users of `wasm-bindgen` should upgrade to at least version 0.2.89, otherwise compilation will fail. | ||
- [Remove long-deprecated no-op attributes `#![no_start]` and `#![crate_id]`.](https://github.com/rust-lang/rust/pull/134300) | ||
- [The future incompatibility lint `cenum_impl_drop_cast` has been made into a hard error.](https://github.com/rust-lang/rust/pull/135964) This means it is now an error to cast a field-less enum to an integer if the enum implements `Drop`. | ||
- [SSE2 is now required for "i686" 32-bit x86 hard-float targets; disabling it causes a warning that will become a hard error eventually.](https://github.com/rust-lang/rust/pull/137037) | ||
To compile for pre-SSE2 32-bit x86, use a "i586" target instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit late now (I'm not sure I want to stop the r+
), but the removal of RustcEncodable
/ RustcDecodable
is a breaking change we should probably note as a follow-up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wondering how we missed this PR (#134272), but it is there quietly in the "Libraries" section. Yes, we should add a compat note as well, and let's do that as a followup -- on master only at this point, but that will also render in GitHub releases, at least.
Add release notes for 1.86.0 Closes rust-lang#138795 (the draft) cc `@rust-lang/release` `@rustbot` ping relnotes-interest-group
Add release notes for 1.86.0 Closes rust-lang#138795 (the draft) cc ``@rust-lang/release`` ``@rustbot`` ping relnotes-interest-group
Rollup of 12 pull requests Successful merges: - rust-lang#110406 (rustdoc-json: Add test for #[automatically_derived] attribute) - rust-lang#137738 (Make slice iterator constructors unstably const) - rust-lang#138492 (remove `feature(inline_const_pat)`) - rust-lang#138928 (Fix UWP reparse point check) - rust-lang#138950 (replace extra_filename with strict version hash in metrics file names) - rust-lang#139002 (Add release notes for 1.86.0) - rust-lang#139022 (increment depth of nested obligations) - rust-lang#139060 (replace commit placeholder in vendor status with actual commit) - rust-lang#139102 (coverage: Avoid splitting spans during span extraction/refinement) - rust-lang#139129 (Add tests for slice bounds check optimization) - rust-lang#139188 (PassWrapper: adapt for llvm/llvm-project@94122d58fc77079a291a3d008914…) - rust-lang#139193 (Feed HIR for by-move coroutine body def, since the inliner tries to read its attrs) r? `@ghost` `@rustbot` modify labels: rollup
Add release notes for 1.86.0 Closes rust-lang#138795 (the draft) cc ```@rust-lang/release``` ```@rustbot``` ping relnotes-interest-group
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#110406 (rustdoc-json: Add test for #[automatically_derived] attribute) - rust-lang#138790 (Note potential but private items in show_candidates) - rust-lang#138950 (replace extra_filename with strict version hash in metrics file names) - rust-lang#139002 (Add release notes for 1.86.0) - rust-lang#139022 (increment depth of nested obligations) - rust-lang#139129 (Add tests for slice bounds check optimization) - rust-lang#139188 (PassWrapper: adapt for llvm/llvm-project@94122d58fc77079a291a3d008914…) - rust-lang#139193 (Feed HIR for by-move coroutine body def, since the inliner tries to read its attrs) - rust-lang#139202 (Improve docs of ValTreeKind) r? `@ghost` `@rustbot` modify labels: rollup
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#110406 (rustdoc-json: Add test for #[automatically_derived] attribute) - rust-lang#138790 (Note potential but private items in show_candidates) - rust-lang#139002 (Add release notes for 1.86.0) - rust-lang#139022 (increment depth of nested obligations) - rust-lang#139129 (Add tests for slice bounds check optimization) - rust-lang#139188 (PassWrapper: adapt for llvm/llvm-project@94122d58fc77079a291a3d008914…) - rust-lang#139193 (Feed HIR for by-move coroutine body def, since the inliner tries to read its attrs) - rust-lang#139202 (Improve docs of ValTreeKind) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#139002 - cuviper:relnotes-1.86.0, r=BoxyUwU Add release notes for 1.86.0 Closes rust-lang#138795 (the draft) cc ````@rust-lang/release```` ````@rustbot```` ping relnotes-interest-group
Closes #138795 (the draft)
cc @rust-lang/release
@rustbot ping relnotes-interest-group