Allow boolean literals in check-cfg
#138767
Merged
+31
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Urgau
reviewed
Mar 21, 2025
rust-cloud-vms
bot
force-pushed
the
check-cfg-bool
branch
from
71bb14e to
72b3b24
Compare
This comment has been minimized.
This comment has been minimized.
rust-cloud-vms
bot
force-pushed
the
check-cfg-bool
branch
from
72b3b24 to
5dcfcaa
Compare
|
Procedurally, this change impacts a stable option, the change is quite limited (and could even be considered a consistency bug-fix with @clubby789 could you open a MCP (Major Change Proposal) against the rust-lang/compiler-team repo explaining the change and its motivation so this PR can move forward. @rustbot label +S-waiting-on-MCP -S-waiting-on-review |
rustbot
added
S-waiting-on-MCP
rust-cloud-vms
bot
force-pushed
the
check-cfg-bool
branch
from
5dcfcaa to
9be6359
Compare
3 tasks
|
Opened an MCP: rust-lang/compiler-team#854 |
Urgau
reviewed
Apr 2, 2025
rust-cloud-vms
bot
force-pushed
the
check-cfg-bool
branch
from
9be6359 to
3df2acd
Compare
Urgau
approved these changes
Apr 3, 2025
|
The MCP has been accepted. Let's merge it. @bors r+ rollup |
bors
added
the
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 3, 2025
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#138017 (Tighten up assignment operator representations.) - rust-lang#138462 (Dedup `&mut *` reborrow suggestion in loops) - rust-lang#138610 (impl !PartialOrd for HirId) - rust-lang#138767 (Allow boolean literals in `check-cfg`) - rust-lang#139068 (io: Avoid marking some bytes as uninit) - rust-lang#139255 (Remove unused variables generated in merged doctests) - rust-lang#139270 (Add a mailmap entry for myself) - rust-lang#139303 (Put Noratrieb on vacation) - rust-lang#139312 (add Marco Ieni to mailmap) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 4, 2025
Rollup merge of rust-lang#138767 - clubby789:check-cfg-bool, r=Urgau Allow boolean literals in `check-cfg` rust-lang#138632 (comment) This makes it consistent with `--cfg` We could alternatively add a forward-compatible lint against `--cfg true/false` r? `@Urgau`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#138632 (comment)
This makes it consistent with
--cfgWe could alternatively add a forward-compatible lint against
--cfg true/falser? @Urgau