-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use warn(unused_crate_dependencies)
in compiler crates.
#137911
Use warn(unused_crate_dependencies)
in compiler crates.
#137911
Conversation
This comment has been minimized.
This comment has been minimized.
The commit also removes fifteen unnecessary dependencies from `Cargo.toml` files that this finds. And tweaks some conditional dependencies. There are three crates with false positives, relating to tests and doc comments. For these three crates `allow(unused_crate_dependencies)` is used along with an explanatory comment.
4c4501f
to
d65cd4f
Compare
The job Click to see the possible cause of the failure (guessed by this bot)
|
Perhaps investigate whether it's possible to globally enable the warnign for all compiler crates in somewhere like here: https://github.com/rust-lang/rust/blob/master/src/bootstrap/src/core/builder/cargo.rs#L1074 Then we can allow it in just the crates that need to be special, and we get it for free in new crates that get introduced ot the compiler. |
I've done this in #137930, I think it worked out pretty well. |
The commit also removes fifteen unnecessary dependencies from
Cargo.toml
files that this finds. And tweaks some conditional dependencies.There are three crates with false positives, relating to tests and doc comments. For these three crates
allow(unused_crate_dependencies)
is used along with an explanatory comment.r? @ghost