-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only strip librustc_driver
and libLLVM
during x dist
#126494
Conversation
@bors try @rust-timer queue Just to check that artifact sizes haven't regressed. |
This comment has been minimized.
This comment has been minimized.
Only strip `librustc_driver` and `libLLVM` during `x dist` The strip invocation can be quite slow (~1-2 seconds), and it is executed on every compiler bootstrap refresh when debuginfo is turned off, which can make most bootstrap commands quite slow. Discussed [here](https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/Only.20strip.20LLVM.2Frustc.20in.20the.20dist.20profile). r? `@lqd`
I'm not an expert in bootstrap but this seems good to me; |
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (9993e27): comparison URL. Overall result: no relevant changes - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary 2.2%, secondary 2.9%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (primary -1.0%, secondary -2.0%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 671.997s -> 672.382s (0.06%) |
Crap. In I'm tempted to switch the condition to Probably the right fix is to move the strip to the |
708099a
to
14d3811
Compare
I modified Because Right now, it's only done for |
@bors try |
Only strip `librustc_driver` and `libLLVM` during `x dist` The strip invocation can be quite slow (~1-2 seconds), and it is executed on every compiler bootstrap refresh when debuginfo is turned off, which can make most bootstrap commands quite slow. Discussed [here](https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/Only.20strip.20LLVM.2Frustc.20in.20the.20dist.20profile). r? `@lqd`
The job Click to see the possible cause of the failure (guessed by this bot)
|
The job Click to see the possible cause of the failure (guessed by this bot)
|
💔 Test failed - checks-actions |
Looks like we can't strip after BOLTing the library. Wonderful. |
Yes that's what caused #112286 |
I'll let this go for now, and switch to using |
The strip invocation can be quite slow (~1-2 seconds), and it is executed on every compiler bootstrap refresh when debuginfo is turned off, which can make most bootstrap commands quite slow. Discussed here.
r? @lqd