add error message for c# style named arguments #118733

nouritsu · 2023-12-08T06:38:53Z

This is a duplicate of the now closed #118532

rustbot · 2023-12-08T06:39:01Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @estebank (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

@rustbot author: the review is finished, PR author should check the comments and take action accordingly
@rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

compiler/rustc_parse/src/parser/expr.rs

rustbot · 2023-12-12T16:40:50Z

There are merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged.

You can start a rebase with the following commands:

$ # rebase
$ git rebase -i master
$ # delete any merge commits in the editor that appears
$ git push --force-with-lease

The following commits are merge commits:

4d2e272

nouritsu · 2023-12-12T16:49:55Z

I ran the rebase command, why is there a conflict still?

compiler-errors

You need to fix all these merge conflicts. You'll probably have the best success by just blessing all the tests over again: ./x.py test tests/ui --bless.

Then please squash all of your commits into one.

tests/ui/type/type-ascription-precedence.stderr

nouritsu · 2023-12-12T20:14:22Z

Okay, I think I did everything right. I have a single commit with blessed tests and the code I intended to add. However, some tests are still failing and I cannot understand why.

compiler-errors · 2023-12-12T20:17:25Z

Actually, now that I look at the test output changes, I wonder if this is not the right place to put this code.

This seems to step on the recovery for the old "type ascription" feature, (expr: Ty).

I'm not sure if I have a good solution for this off the top of my head. I recommend reading the parser code for function arg parsing more closely to see if there's a better place to put this.

Sorry for the churn 😅 but that's just how working in the parser is sometimes.

nouritsu · 2023-12-12T20:26:21Z

Actually, now that I look at the test output changes, I wonder if this is not the right place to put this code.

This seems to step on the recovery for the old "type ascription" feature, (expr: Ty).

I'm not sure if I have a good solution for this off the top of my head. I recommend reading the parser code for function arg parsing more closely to see if there's a better place to put this.

Sorry for the churn 😅 but that's just how working in the parser is sometimes.

@/estebank had suggested a solution of trying to parse a type after a snapshot is taken. Is there a way this could be used?

tests/ui/parser/issues/issue-111416.stderr

estebank · 2023-12-19T20:44:55Z

tests/ui/parser/issues/issue-111416.stderr

-help: if `monad_bind` is a struct, use braces as delimiters
+   |                              ^ expected identifier
   |
-LL |     let my = monad_bind { mx, T: Try };
-   |                         ~            ~


Still sad of losing this suggestion.

Would it be possible for me to add on this suggestion along with the named arguments error? something like -

if this is a parameter, remove the parameter name ... if this is a struct, use braces as delimiters ...

Yes, you could likely include it to. Look at the existing one because there's some subtlety here: this suggestion is only potentially valid if all the previous expressions in the argument list are either an ident (like mx) or the type ascription (which is no longer represented in the expression syntax tree, the T: Try), so we only emit the that suggestion if when encountering the problem, all prior args are just idents. We would also want to remove the older logic as now it won't trigger anymore.

I understand, I'll take a look at the existing solution and try to adapt it to this. Can we go over other changes that should be made to get all the tests to pass?

bless tests

rust-log-analyzer · 2023-12-20T06:48:15Z

The job x86_64-gnu-llvm-16 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

GITHUB_ACTION=__run_7
GITHUB_ACTIONS=true
GITHUB_ACTION_REF=
GITHUB_ACTION_REPOSITORY=
GITHUB_ACTOR=nouritsu
GITHUB_API_URL=https://api.github.com
GITHUB_BASE_REF=master
GITHUB_ENV=/home/runner/work/_temp/_runner_file_commands/set_env_c9e975c7-6e26-4451-88c1-fe442c29aad3
GITHUB_EVENT_NAME=pull_request
---
GITHUB_SERVER_URL=https://github.com
GITHUB_SHA=57819b3c36d84b83e0a0ef6c7485908dc8f9c442
GITHUB_STATE=/home/runner/work/_temp/_runner_file_commands/save_state_c9e975c7-6e26-4451-88c1-fe442c29aad3
GITHUB_STEP_SUMMARY=/home/runner/work/_temp/_runner_file_commands/step_summary_c9e975c7-6e26-4451-88c1-fe442c29aad3
GITHUB_TRIGGERING_ACTOR=nouritsu
GITHUB_WORKFLOW_REF=rust-lang/rust/.github/workflows/ci.yml@refs/pull/118733/merge
GITHUB_WORKFLOW_SHA=57819b3c36d84b83e0a0ef6c7485908dc8f9c442
GITHUB_WORKSPACE=/home/runner/work/rust/rust
GOROOT_1_19_X64=/opt/hostedtoolcache/go/1.19.13/x64
---
Built container sha256:9c3c93a371e5aed5c18185b24f130d95d5140dbd72a9b325e7b6b49e521a4faa
Looks like docker image is the same as before, not uploading
https://ci-caches.rust-lang.org/docker/7ebc15c01a233894034d277c8cce4e949f4e7791f66b4727c8fb6e058a0b8171d6152e1441d677cef0653843ceeee469c097b8699b2bb74249e674f6aa1a8813
sha256:9c3c93a371e5aed5c18185b24f130d95d5140dbd72a9b325e7b6b49e521a4faa
Setting extra environment values for docker:  --env ENABLE_GCC_CODEGEN=1 --env GCC_EXEC_PREFIX=/usr/lib/gcc/
[CI_JOB_NAME=x86_64-gnu-llvm-16]
##[group]Clock drift check
  local time: Wed Dec 20 06:34:04 UTC 2023
  network time: Wed, 20 Dec 2023 06:34:04 GMT
  network time: Wed, 20 Dec 2023 06:34:04 GMT
##[endgroup]
sccache: Starting the server...
##[group]Configure the build
configure: processing command line
configure: 
configure: build.configure-args := ['--build=x86_64-unknown-linux-gnu', '--llvm-root=/usr/lib/llvm-16', '--enable-llvm-link-shared', '--set', 'rust.thin-lto-import-instr-limit=10', '--enable-verbose-configure', '--enable-sccache', '--disable-manage-submodules', '--enable-locked-deps', '--enable-cargo-native-static', '--set', 'rust.codegen-units-std=1', '--set', 'dist.compression-profile=balanced', '--dist-compression-formats=xz', '--disable-dist-src', '--release-channel=nightly', '--enable-debug-assertions', '--enable-overflow-checks', '--enable-llvm-assertions', '--set', 'rust.verify-llvm-ir', '--set', 'rust.codegen-backends=llvm,cranelift,gcc', '--set', 'llvm.static-libstdcpp', '--enable-missing-tools', '--enable-new-symbol-mangling']
configure: target.x86_64-unknown-linux-gnu.llvm-config := /usr/lib/llvm-16/bin/llvm-config
configure: llvm.link-shared     := True
configure: rust.thin-lto-import-instr-limit := 10
configure: rust.codegen-units-std := 1
---
.................i.............................................i........................ 10384/15970
........................................................i............................... 10472/15970
........................................................................................ 10560/15970
........................................................................................ 10648/15970
..........i......F.....F................................................................ 10736/15970
..................................................F..................................... 10824/15970
..........................................................F............................. 11000/15970
........................................................................................ 11088/15970
........................................................................................ 11176/15970
........................................................................................ 11264/15970
---
---- [ui] tests/ui/parser/issues/issue-34255-1.rs stdout ----

error: /checkout/tests/ui/parser/issues/issue-34255-1.rs:8: unexpected error: '8:22: 8:23: expected expression, found `:`'

error: /checkout/tests/ui/parser/issues/issue-34255-1.rs:8: unexpected error: '8:22: 8:23: expected one of `!`, `)`, `,`, `.`, `::`, `?`, `{`, or an operator, found `:`'
error: /checkout/tests/ui/parser/issues/issue-34255-1.rs:8: unexpected error: '8:17: 8:22: cannot find value `field` in this scope [E0425]'


error: /checkout/tests/ui/parser/issues/issue-34255-1.rs:8: unexpected error: '8:5: 8:16: expected value, found struct variant `Test::Drill` [E0533]'

error: /checkout/tests/ui/parser/issues/issue-34255-1.rs:8: expected error not found: invalid `struct` delimiters or `fn` call arguments
error: 4 unexpected errors found, 1 expected errors not found
status: exit status: 1
status: exit status: 1
command: RUSTC_ICE="0" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/parser/issues/issue-34255-1.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/parser/issues/issue-34255-1" "-A" "unused" "-A" "internal_features" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/parser/issues/issue-34255-1/auxiliary"
    Error {
        line_num: 8,
        kind: Some(
            Error,
---
        line_num: 8,
        kind: Some(
            Error,
        ),
        msg: "8:22: 8:23: expected one of `!`, `)`, `,`, `.`, `::`, `?`, `{`, or an operator, found `:`",
    Error {
        line_num: 8,
        kind: Some(
            Error,
---
        line_num: 8,
        kind: Some(
            Error,
        ),
        msg: "8:5: 8:16: expected value, found struct variant `Test::Drill` [E0533]",
]

not found errors (from test file): [
    Error {
    Error {
        line_num: 8,
        kind: Some(
            Error,
        ),
        msg: "invalid `struct` delimiters or `fn` call arguments",
]

thread '[ui] tests/ui/parser/issues/issue-34255-1.rs' panicked at src/tools/compiletest/src/runtest.rs:1825:13:
explicit panic
explicit panic

---- [ui] tests/ui/parser/issues/issue-44406.rs stdout ----

error: /checkout/tests/ui/parser/issues/issue-44406.rs:3: unexpected error: '3:16: 3:17: expected expression, found `:`'

error: /checkout/tests/ui/parser/issues/issue-44406.rs:3: unexpected error: '3:16: 3:17: expected one of `!`, `)`, `,`, `.`, `::`, `?`, `{`, or an operator, found `:`'

error: /checkout/tests/ui/parser/issues/issue-44406.rs:3: unexpected error: '3:13: 3:16: cannot find value `baz` in this scope [E0425]'

error: /checkout/tests/ui/parser/issues/issue-44406.rs:3: unexpected error: '3:9: 3:12: cannot find function `bar` in this scope [E0425]'

error: /checkout/tests/ui/parser/issues/issue-44406.rs:3: expected error not found: invalid `struct` delimiters or `fn` call arguments
error: 4 unexpected errors found, 1 expected errors not found
status: exit status: 1
status: exit status: 1
command: RUSTC_ICE="0" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/parser/issues/issue-44406.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/parser/issues/issue-44406" "-A" "unused" "-A" "internal_features" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/parser/issues/issue-44406/auxiliary"
    Error {
        line_num: 3,
        kind: Some(
            Error,
---
        line_num: 3,
        kind: Some(
            Error,
        ),
        msg: "3:16: 3:17: expected one of `!`, `)`, `,`, `.`, `::`, `?`, `{`, or an operator, found `:`",
    Error {
        line_num: 3,
        kind: Some(
            Error,
            Error,
        ),
        msg: "3:13: 3:16: cannot find value `baz` in this scope [E0425]",
    Error {
        line_num: 3,
        kind: Some(
            Error,
            Error,
        ),
        msg: "3:9: 3:12: cannot find function `bar` in this scope [E0425]",
]

not found errors (from test file): [
    Error {
    Error {
        line_num: 3,
        kind: Some(
            Error,
        ),
        msg: "invalid `struct` delimiters or `fn` call arguments",
]

thread '[ui] tests/ui/parser/issues/issue-44406.rs' panicked at src/tools/compiletest/src/runtest.rs:1825:13:
explicit panic
explicit panic

---- [ui] tests/ui/parser/issues/issue-91461.rs stdout ----

error: /checkout/tests/ui/parser/issues/issue-91461.rs:2: unexpected error: '2:8: 2:9: expected expression, found `:`'

error: /checkout/tests/ui/parser/issues/issue-91461.rs:2: unexpected error: '2:10: 2:11: expected one of `!`, `)`, `,`, `.`, `::`, `?`, `{`, or an operator, found `:`'
error: 2 unexpected errors found, 0 expected errors not found
status: exit status: 1
status: exit status: 1
command: RUSTC_ICE="0" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/parser/issues/issue-91461.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/parser/issues/issue-91461" "-A" "unused" "-A" "internal_features" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/parser/issues/issue-91461/auxiliary"
    Error {
        line_num: 2,
        kind: Some(
            Error,
---
        line_num: 2,
        kind: Some(
            Error,
        ),
        msg: "2:10: 2:11: expected one of `!`, `)`, `,`, `.`, `::`, `?`, `{`, or an operator, found `:`",
]

thread '[ui] tests/ui/parser/issues/issue-91461.rs' panicked at src/tools/compiletest/src/runtest.rs:1825:13:
explicit panic
explicit panic

---- [ui] tests/ui/parser/recover/recover-from-bad-variant.rs stdout ----

error: /checkout/tests/ui/parser/recover/recover-from-bad-variant.rs:7: unexpected error: '7:24: 7:25: expected expression, found `:`'

error: /checkout/tests/ui/parser/recover/recover-from-bad-variant.rs:7: unexpected error: '7:24: 7:25: expected one of `!`, `)`, `,`, `.`, `::`, `?`, `{`, or an operator, found `:`'
error: /checkout/tests/ui/parser/recover/recover-from-bad-variant.rs:7: unexpected error: '7:30: 7:31: expected expression, found `:`'


error: /checkout/tests/ui/parser/recover/recover-from-bad-variant.rs:7: unexpected error: '7:30: 7:31: expected one of `!`, `)`, `,`, `.`, `::`, `?`, `{`, or an operator, found `:`'

error: /checkout/tests/ui/parser/recover/recover-from-bad-variant.rs:7: unexpected error: '7:23: 7:24: cannot find value `a` in this scope [E0425]'

error: /checkout/tests/ui/parser/recover/recover-from-bad-variant.rs:7: unexpected error: '7:29: 7:30: cannot find value `b` in this scope [E0425]'
error: /checkout/tests/ui/parser/recover/recover-from-bad-variant.rs:7: unexpected error: '7:13: 7:22: expected value, found struct variant `Enum::Foo` [E0533]'


error: /checkout/tests/ui/parser/recover/recover-from-bad-variant.rs:7: expected error not found: invalid `struct` delimiters or `fn` call arguments
error: 7 unexpected errors found, 1 expected errors not found
status: exit status: 1
command: RUSTC_ICE="0" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/parser/recover/recover-from-bad-variant.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/parser/recover/recover-from-bad-variant" "-A" "unused" "-A" "internal_features" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/parser/recover/recover-from-bad-variant/auxiliary"
unexpected errors (from JSON output): [
---
        line_num: 7,
        kind: Some(
            Error,
        ),
        msg: "7:24: 7:25: expected one of `!`, `)`, `,`, `.`, `::`, `?`, `{`, or an operator, found `:`",
    Error {
        line_num: 7,
        kind: Some(
            Error,
---
        line_num: 7,
        kind: Some(
            Error,
        ),
        msg: "7:30: 7:31: expected one of `!`, `)`, `,`, `.`, `::`, `?`, `{`, or an operator, found `:`",
    Error {
        line_num: 7,
        kind: Some(
            Error,
            Error,
        ),
        msg: "7:23: 7:24: cannot find value `a` in this scope [E0425]",
    Error {
        line_num: 7,
        kind: Some(
            Error,
            Error,
        ),
        msg: "7:29: 7:30: cannot find value `b` in this scope [E0425]",
    Error {
        line_num: 7,
        kind: Some(
            Error,
---
        line_num: 7,
        kind: Some(
            Error,
        ),
        msg: "invalid `struct` delimiters or `fn` call arguments",
]

thread '[ui] tests/ui/parser/recover/recover-from-bad-variant.rs' panicked at src/tools/compiletest/src/runtest.rs:1825:13:
explicit panic
explicit panic

---- [ui] tests/ui/type/type-ascription-precedence.rs stdout ----

error: /checkout/tests/ui/type/type-ascription-precedence.rs:33: unexpected error: '33:5: 33:12: type `Z` cannot be dereferenced [E0614]'

error: /checkout/tests/ui/type/type-ascription-precedence.rs:37: unexpected error: '37:5: 37:12: cannot apply unary operator `-` to type `Z` [E0600]'
error: 2 unexpected errors found, 0 expected errors not found
status: exit status: 1
command: RUSTC_ICE="0" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/type/type-ascription-precedence.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/type/type-ascription-precedence" "-A" "unused" "-A" "internal_features" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/type/type-ascription-precedence/auxiliary"
unexpected errors (from JSON output): [
unexpected errors (from JSON output): [
    Error {
        line_num: 33,
        kind: Some(
            Error,
        ),
        msg: "33:5: 33:12: type `Z` cannot be dereferenced [E0614]",
    Error {
        line_num: 37,
        kind: Some(
            Error,
            Error,
        ),
        msg: "37:5: 37:12: cannot apply unary operator `-` to type `Z` [E0600]",
]

thread '[ui] tests/ui/type/type-ascription-precedence.rs' panicked at src/tools/compiletest/src/runtest.rs:1825:13:
explicit panic

nouritsu · 2024-01-02T09:39:05Z

So, how should we move forward with this?

Dylan-DPC · 2024-02-19T11:00:27Z

@nouritsu any updates on this? thanks

nouritsu · 2024-02-21T06:56:39Z

@Dylan-DPC this PR is awaiting a response from a reviewer. It cannot be merged because it messes up the error messages for type ascription. I'm not sure how to proceed with this, but my current solution is nowhere near ready to be merged.

wesleywiser · 2024-09-26T14:49:24Z

Hi @estebank, do you have suggestions for the author on how to proceed?

bors · 2025-02-11T05:34:49Z

☔ The latest upstream changes (presumably #127541) made this pull request unmergeable. Please resolve the merge conflicts.

rustbot assigned estebank Dec 8, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 8, 2023

This comment has been minimized.

Sign in to view

compiler-errors requested changes Dec 11, 2023

View reviewed changes

compiler/rustc_parse/src/parser/expr.rs Outdated Show resolved Hide resolved

compiler-errors assigned compiler-errors and unassigned estebank Dec 11, 2023

rustbot added has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 12, 2023

This comment has been minimized.

Sign in to view

compiler-errors requested changes Dec 12, 2023

View reviewed changes

tests/ui/type/type-ascription-precedence.stderr Outdated Show resolved Hide resolved

rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 12, 2023

nouritsu force-pushed the master branch from 4d2e272 to 359bd1d Compare December 12, 2023 20:13

This comment has been minimized.

Sign in to view

nouritsu mentioned this pull request Dec 16, 2023

C#-style named arguments emit type ascription errors #116411

Open

estebank reviewed Dec 19, 2023

View reviewed changes

tests/ui/parser/issues/issue-111416.stderr Show resolved Hide resolved

estebank reviewed Dec 19, 2023

View reviewed changes

add error message for c# style named arguments

378d28c

bless tests

nouritsu force-pushed the master branch from 359bd1d to 378d28c Compare December 20, 2023 06:32

dtolnay removed the has-merge-commits PR has merge commits, merge with caution. label Jan 21, 2024

oskgo added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 9, 2024

compiler-errors assigned estebank and unassigned compiler-errors Aug 12, 2024

nouritsu closed this Feb 22, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add error message for c# style named arguments #118733

add error message for c# style named arguments #118733

nouritsu commented Dec 8, 2023

rustbot commented Dec 8, 2023

This comment has been minimized.

rustbot commented Dec 12, 2023

nouritsu commented Dec 12, 2023

This comment has been minimized.

compiler-errors left a comment

nouritsu commented Dec 12, 2023

compiler-errors commented Dec 12, 2023

nouritsu commented Dec 12, 2023

This comment has been minimized.

estebank Dec 19, 2023

nouritsu Dec 20, 2023

estebank Dec 20, 2023

nouritsu Dec 25, 2023

rust-log-analyzer commented Dec 20, 2023

nouritsu commented Jan 2, 2024

Dylan-DPC commented Feb 19, 2024

nouritsu commented Feb 21, 2024

wesleywiser commented Sep 26, 2024

bors commented Feb 11, 2025

add error message for c# style named arguments #118733

add error message for c# style named arguments #118733

Conversation

nouritsu commented Dec 8, 2023

rustbot commented Dec 8, 2023

This comment has been minimized.

rustbot commented Dec 12, 2023

nouritsu commented Dec 12, 2023

This comment has been minimized.

compiler-errors left a comment

Choose a reason for hiding this comment

nouritsu commented Dec 12, 2023

compiler-errors commented Dec 12, 2023

nouritsu commented Dec 12, 2023

This comment has been minimized.

estebank Dec 19, 2023

Choose a reason for hiding this comment

nouritsu Dec 20, 2023

Choose a reason for hiding this comment

estebank Dec 20, 2023

Choose a reason for hiding this comment

nouritsu Dec 25, 2023

Choose a reason for hiding this comment

rust-log-analyzer commented Dec 20, 2023

nouritsu commented Jan 2, 2024

Dylan-DPC commented Feb 19, 2024

nouritsu commented Feb 21, 2024

wesleywiser commented Sep 26, 2024

bors commented Feb 11, 2025