-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Document policy for adding custom test jobs/components to rust-lang/rust CI #813
base: master
Are you sure you want to change the base?
Conversation
Blocked on opening an MCP for this first. |
154c3e5
to
e771902
Compare
e771902
to
625effb
Compare
625effb
to
3c0264c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks. The diagram kind of shows how desynchronized are the decision processes between t-compiler and t-libs (and other teams) currently :) Left some comments.
src/compiler/proposals-and-stabilization/custom-test-jobs/test-job-flow.svg
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nits, but this looks great.
Changes since last review:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FIXME(jieyouxu): rename this file to sth like ecosystem-integration-tests.md
and fix links before merge.
Changes since last push:
|
Changes since last push (take 2):
|
Caution
Do not merge, this is open for feedback, blocked on the MCP being seconded and accepted.
Tip
For review purposes, this PR will initially have a lot of intermediate commits to make review history more clear, but they are intended be squashed away before ready for merge.
MCP: rust-lang/compiler-team#845
MCP thread: #t-compiler/major changes > Policy: Require MCP and relevant team nom… compiler-team#845
rust-lang/rust issue: rust-lang/rust#137960
Following discussions in https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/RFL.20CI.20Job.
Not sure if T-infra wants this to be documented somewhere... cc @rust-lang/infra
r? @davidtwco (or @wesleywiser)
Rendered