Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Document policy for adding custom test jobs/components to rust-lang/rust CI #813

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

jieyouxu
Copy link
Member

@jieyouxu jieyouxu commented Feb 28, 2025

Caution

Do not merge, this is open for feedback, blocked on the MCP being seconded and accepted.

Tip

For review purposes, this PR will initially have a lot of intermediate commits to make review history more clear, but they are intended be squashed away before ready for merge.

MCP: rust-lang/compiler-team#845
MCP thread: #t-compiler/major changes > Policy: Require MCP and relevant team nom… compiler-team#845
rust-lang/rust issue: rust-lang/rust#137960

Following discussions in https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/RFL.20CI.20Job.

Not sure if T-infra wants this to be documented somewhere... cc @rust-lang/infra

r? @davidtwco (or @wesleywiser)

Rendered

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 28, 2025
@jieyouxu jieyouxu added T-compiler Team: Compiler T-infra Team: Infrastructure labels Feb 28, 2025
@jieyouxu
Copy link
Member Author

jieyouxu commented Mar 3, 2025

Blocked on opening an MCP for this first.
@rustbot blocked

EDIT: rust-lang/compiler-team#845

@rustbot rustbot added S-blocked Status: Blocked on something else such as a PR in another repository. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 3, 2025
@jieyouxu jieyouxu force-pushed the mcp-for-ecosystem-testing branch 2 times, most recently from 154c3e5 to e771902 Compare March 20, 2025 14:36
@jieyouxu jieyouxu changed the title Require compiler MCP for adding new Ecosystem Testing CI job [WIP] Document policy for adding custom test jobs/components to rust-lang/rust CI Mar 20, 2025
@jieyouxu jieyouxu force-pushed the mcp-for-ecosystem-testing branch from e771902 to 625effb Compare March 20, 2025 14:42
@jieyouxu jieyouxu force-pushed the mcp-for-ecosystem-testing branch from 625effb to 3c0264c Compare March 21, 2025 06:24
Copy link
Contributor

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks. The diagram kind of shows how desynchronized are the decision processes between t-compiler and t-libs (and other teams) currently :) Left some comments.

Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits, but this looks great.

@jieyouxu
Copy link
Member Author

Changes since last review:

  • Hard-wrapped to 100 columns.
  • Changed terminology to use "ecosystem/integration test jobs/components" instead.
  • Spelled out the process (instead of just having the diagram).
  • Adjusted process (text and diagram) to ask infra about capacity first (discussed in #t-infra > Policy for adding custom test jobs/components to r-l/r CI).
  • Dropped mentions about ping groups because only team members + certain WG members can use triagebot ping group anyway.
  • Adjusted scope wording.

Copy link
Member Author

@jieyouxu jieyouxu Mar 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FIXME(jieyouxu): rename this file to sth like ecosystem-integration-tests.md and fix links before merge.

@jieyouxu
Copy link
Member Author

Changes since last push:

@jieyouxu
Copy link
Member Author

Changes since last push (take 2):

  • Looking at Enable autodiff testcases in CI compiler-team#855 again, I converted the policy template into a markdown block, because when this template (previously) get rendered into a webpage, copy-pasting completely loses the markdown formatting. Instead, present the policy template as a markdown codeblock (raw markdown annotations) so pasting it into e.g. an MCP will become properly formatted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-blocked Status: Blocked on something else such as a PR in another repository. T-compiler Team: Compiler T-infra Team: Infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants