-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding secure_getenv for solaris/illumos. #4342
Conversation
a8b4da1
to
b32b34f
Compare
libc-test/build.rs
Outdated
@@ -1253,6 +1253,9 @@ fn test_solarish(target: &str) { | |||
// https://github.com/gnzlbg/ctest/issues/68 | |||
"lio_listio" => true, | |||
|
|||
// Exists on illumos too but, for now, is a recent addition. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment won't age well. Perhaps include the bug number for its introduction (17094), the date of its introduction (2025-01-29), or just link to https://www.illumos.org/issues/17094 ?
b32b34f
to
351a99d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rustbot label +stable-nominated
[solaris](https://docs.oracle.com/cd/E88353_01/html/E37843/secure-getenv-3c.html) [illumos](https://github.com/illumos/illumos-gate/blob/dc7ec32189c86a0f330aee77229dad2ad57eac71/usr/src/man/man3c/getenv.3c#L12) (backport <rust-lang#4342>) (cherry picked from commit 351a99d)
solaris illumos