Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding secure_getenv for solaris/illumos. #4342

Merged
merged 1 commit into from
Mar 22, 2025

Conversation

devnexen
Copy link
Contributor

@rustbot
Copy link
Collaborator

rustbot commented Mar 19, 2025

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot
Copy link
Collaborator

rustbot commented Mar 19, 2025

Some changes occurred in solarish module

cc @jclulow, @pfmooney

@devnexen devnexen force-pushed the secure_getenv_solarish branch from a8b4da1 to b32b34f Compare March 19, 2025 19:46
@@ -1253,6 +1253,9 @@ fn test_solarish(target: &str) {
// https://github.com/gnzlbg/ctest/issues/68
"lio_listio" => true,

// Exists on illumos too but, for now, is a recent addition.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment won't age well. Perhaps include the bug number for its introduction (17094), the date of its introduction (2025-01-29), or just link to https://www.illumos.org/issues/17094 ?

@devnexen devnexen force-pushed the secure_getenv_solarish branch from b32b34f to 351a99d Compare March 19, 2025 19:54
Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rustbot label +stable-nominated

@rustbot rustbot added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Mar 22, 2025
@tgross35 tgross35 added this pull request to the merge queue Mar 22, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 22, 2025
@tgross35 tgross35 added this pull request to the merge queue Mar 22, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 22, 2025
@tgross35 tgross35 added this pull request to the merge queue Mar 22, 2025
Merged via the queue into rust-lang:main with commit fdeca3b Mar 22, 2025
43 checks passed
@tgross35 tgross35 mentioned this pull request Apr 3, 2025
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-solarish O-unix S-waiting-on-review stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants