Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes too make the CI green #2885

Merged
merged 7 commits into from
Sep 14, 2024
Merged

Various fixes too make the CI green #2885

merged 7 commits into from
Sep 14, 2024

Conversation

hkratz
Copy link
Contributor

@hkratz hkratz commented Sep 14, 2024

Split into semantically separate commits for easier reviewing.

compiler warnings:

clippy lints:

clippy doc lints:

@hkratz hkratz changed the title Fix CI: unexpected cfg condition name: nightly Fix CI: unexpected cfg condition name: ... Sep 14, 2024
@hkratz hkratz force-pushed the fix-ci branch 2 times, most recently from 5e19314 to 1be6431 Compare September 14, 2024 07:56
@hkratz hkratz changed the title Fix CI: unexpected cfg condition name: ... Various fixes too make the CI green Sep 14, 2024
@hkratz hkratz marked this pull request as ready for review September 14, 2024 08:29
Copy link
Member

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM aside from a nit.

futures/build.rs Outdated Show resolved Hide resolved
@taiki-e taiki-e merged commit ebaf1a2 into rust-lang:master Sep 14, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants