Skip to content

Remove ember-fetch dependency #10956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 8, 2025
Merged

Remove ember-fetch dependency #10956

merged 3 commits into from
Apr 8, 2025

Conversation

mansona
Copy link
Contributor

@mansona mansona commented Apr 7, 2025

This is a really basic change assuming all network goes through your helper function

See more info here: https://rfcs.emberjs.com/id/1065-remove-ember-fetch/

@Turbo87 Turbo87 changed the title remove ember-fetch Remove ember-fetch dependency Apr 7, 2025
@Turbo87 Turbo87 added A-frontend 🐹 C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear labels Apr 7, 2025
@Turbo87
Copy link
Member

Turbo87 commented Apr 8, 2025

thanks @mansona! I've added additional waitForPromise() wrappers around the response.text() and response.json() calls, and it looks like CI is happy with this now! 🎉

@Turbo87 Turbo87 merged commit ed93378 into rust-lang:main Apr 8, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Turbo87 Turbo87 Turbo87 approved these changes

Assignees
No one assigned
Labels
A-frontend 🐹 C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mansona @Turbo87