Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add CARGO_MANIFEST_PATH env variable #14404

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Ifropc
Copy link
Contributor

@Ifropc Ifropc commented Aug 15, 2024

Adds CARGO_MANIFEST_PATH variable as part of #12207
Context: CARGO_MANIFEST_DIR is not very useful, because there is no Cargo.toml file when running a cargo script. In cases when multiple scripts are stored in the same folder, we can't tell which script exactly is being run using CARGO_MANIFEST_DIR

@rustbot
Copy link
Collaborator

rustbot commented Aug 15, 2024

r? @epage

rustbot has assigned @epage.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-build-execution Area: anything dealing with executing the compiler A-build-scripts Area: build.rs scripts A-documenting-cargo-itself Area: Cargo's documentation S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 15, 2024
@epage epage added the T-cargo Team: Cargo label Aug 15, 2024
@epage
Copy link
Contributor

epage commented Aug 15, 2024

@rfcbot merge

This PR insta-stabilizes CARGO_MANIFEST_PATH, a companion to CARGO_MANIFEST_DIR for when you actually want the manifest because CARGO_MANIFEST_DIR.join("Cargo.toml") will no longer be sufficient due to cargo-script.

@rfcbot
Copy link
Collaborator

rfcbot commented Aug 15, 2024

Team member @epage has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period An FCP proposal has started, but not yet signed off. disposition-merge FCP with intent to merge labels Aug 15, 2024
@Ifropc Ifropc force-pushed the cargo_manifest_path branch 3 times, most recently from 8083492 to 58a807f Compare August 15, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-build-execution Area: anything dealing with executing the compiler A-build-scripts Area: build.rs scripts A-documenting-cargo-itself Area: Cargo's documentation disposition-merge FCP with intent to merge proposed-final-comment-period An FCP proposal has started, but not yet signed off. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-cargo Team: Cargo
Projects
Status: FCP merge
Development

Successfully merging this pull request may close these issues.

5 participants