Initial layout #13
Initial layout #13
Conversation
…ng-ar.github.io into Initial-Layout
…ng-ar.github.io into Initial-Layout
|
@Phosphorus-M I think it would be nice to have screenshots here, so we can see what's being merged |
|
@Phosphorus-M please fix GitHub actions cargo fmt && cargo clippy |
Co-authored-by: Esteban Borai <[email protected]>
Co-authored-by: Esteban Borai <[email protected]>
| @@ -0,0 +1,65 @@ | |||
| const path = require('path'); | |||
There was a problem hiding this comment.
I think webpack is too much for this, why not using PostCSS along with Rollup? Is faster and lightweight.
| @@ -0,0 +1,65 @@ | |||
| const path = require('path'); | |||
| const WasmPackPlugin = require('@wasm-tool/wasm-pack-plugin'); | |||
There was a problem hiding this comment.
Is this required? We are using Trunk already so Im not sure why we have a WASM loader here.
|
@Phosphorus-M please make sure you rebase! It makes easier PR reviewing. |
|
The router looks good so far, but I believe we will encounter issues with client side routing given that we are using GitHub Pages which (AFAIK) it doesn't support client-side routing. We would have to either use a hash router for this or change our hosting provider to make it work as expected. |
Agregado en la landing page:
En teoría todo es responsive de momento, faltan varias cosas pero bueno, es un comienzo.
El diseño que se viene usando es este desde luego esta abierto a cambios y sugerencias.