Review: write_raw() must be unsafe

rust-embedded · Jan 23, 2025 · 8279b63 · 8279b63
1 parent 78f7968
commit 8279b63
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/cortex-m/src/interrupt.rs b/cortex-m/src/interrupt.rs
@@ -76,7 +76,9 @@ where
 
     let r = f();
 
-    crate::register::primask::write_raw(primask);
+    unsafe {
+        crate::register::primask::write_raw(primask);
+    }
 
     r
 }

diff --git a/cortex-m/src/register/primask.rs b/cortex-m/src/register/primask.rs
@@ -53,7 +53,7 @@ pub fn read_raw() -> u32 {
 /// Note that bits [31:1] are reserved and SBZP (Should-Be-Zero-or-Preserved)
 #[cfg(cortex_m)]
 #[inline]
-pub fn write_raw(r: u32) {
+pub unsafe fn write_raw(r: u32) {
     // Ensure no preceeding memory accesses are reordered to after interrupts are possibly enabled.
     compiler_fence(Ordering::SeqCst);
     unsafe { asm!("msr PRIMASK, {}", in(reg) r, options(nomem, nostack, preserves_flags)) };