Add PsbtOutputExt::update_with_descriptor
#465
Conversation
This essentially mirrors `PsbtInputExt::update_with_descriptor` but it works on PSBT outputs. To avoid code duplication, the current logic that deals with PSBT inputs has been generalized to handle both input and outputs with a new internal `PsbtFields` trait.
I guess this is a bit of an edge case, but in general I think it's always better to append metadata to a PSBT without removing what's already in there.
Some PSBT may only contain the `non_witness_utxo` to save space, since the `witness_utxo` would be strictly redundant. This should not be considered an error.
|
Sorry if I keep pushing commits here, let me know if you'd like me to open separate PRs. The last commit allows setting just the I may have to push another fix because I'm having a failure in a bdk test since I switched to miniscript's |
|
Turns out nothing was really broken, but calling I fixed it by sorting and the end and then running |
There was a problem hiding this comment.
ACK 9a57e00. Not completely happy with internal trait abstraction. I may work on a future PR to abstract that into a function that takes 1) script pubkey and 2) descriptor and outputs the relevant fields that are added to the psbt.
We can then call this function on the input script pubkey and output script pubkey respectively.
…022_10 2f1535e Merge rust-bitcoin/rust-miniscript#465: Add `PsbtOutputExt::update_with_descriptor` Had to manually change the test vectors because elements has different tagged hashes
c7a43d9 Remove unused code (Alekos Filini) 1ffd59d Upgrade to rust-bitcoin 0.29 (Alekos Filini) ae4f4e5 Upgrade `rand` to `0.8` (Alekos Filini) 9854fd3 Remove deprecated address validators (Alekos Filini) Pull request description: ### Description Upgrade BDK to rust-bitcoin 0.29 Missing pieces: - [x] rust-miniscript `update_output_with_descriptor` - rust-bitcoin/rust-miniscript#465 - [x] rust-miniscript 8.0.0 release - rust-bitcoin/rust-miniscript#462 - [x] Upgrade rust-hwi to bitcoin 0.29 bitcoindevkit/rust-hwi#50 - [x] Upgrade esplora-client to bitcoin 0.29 bitcoindevkit/rust-esplora-client#20 - [x] Upgrade rand to 0.8 like secp256k1 did ### Notes to the reviewers The commits still need to be reordered and cleaned up ### Changelog notice - Upgrade rust-bitcoin to 0.29 - Remove deprecated "address validators" ### Checklists #### All Submissions: * [x] I've signed all my commits * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md) * [x] I ran `cargo fmt` and `cargo clippy` before committing ACKs for top commit: notmandatory: ACK c7a43d9 Tree-SHA512: 718a1baf3613b31ec1de39fe63467ebee38617963a4ce0670a617e20fe4f46a57c5786933cdde6cfad9fc76ce0af08843f58844fb4a89f5948cb42c697f802ef
This essentially mirrors
PsbtInputExt::update_with_descriptorbut it works on PSBT outputs.To avoid code duplication, the current logic that deals with PSBT inputs has been generalized to handle both input and outputs with a new internal
PsbtFieldstrait.I hope it's not too late to get this PR in the new 8.0 release (cc #462)