-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Azure AI Search Vector Store #17651
base: main
Are you sure you want to change the base?
Update Azure AI Search Vector Store #17651
Conversation
- Updated Metadata so you can use either a metadata string (LlamaIndex) or a dict/JSON object where it will extract the default fields, and then assume the remainder is metadata and match your fields - Added new SearchField option configs for the _metadata_filterable_keys - Added new semantic_config (SemanticConfiguration | str | None) and semantic_config_name (I added semantic_config_name for backwards compatibility but) - Added new vector_search_profile (VectorSearchProfile | None) and kept the existing vector_search_profile_name for backwards compatiblity - Changed key_fields to doc_id_field (from doc_id_field_str) to support new str | SearchField - Added more helper methods to try to make it a bit easier to use, I may have gone a bit overboard, but feel free to scale back All Tests Pass, but need to test with an actual Azure Vector Store I would imagine
It wasn't in there originally so I presume it needs to be gone
Turns out the metadata was fine, hopefully this is a beneficial patch
So I guess Azure was returning metadata without ending brackets, so I took this on for not a ton of reason, but after checking my work I would remove the following:
I still stand by the metadata improvements in terms of the filterable_metadata_field_keys being SearchField bases optionally as those are a 1:1, as well as the other QOL stuff like using the custom semantic config, but I can reduce the code (and I will be doing that) |
Not sure if you are still updating this, but in the sake of keeping PRs smaller, going to go ahead and merge this #17683 |
Description
All Tests Pass, but need to test with an actual Azure Vector Store I would imagine
Fixes # (issue)
New Package?
Did I fill in the
tool.llamahub
section in thepyproject.toml
and provide a detailed README.md for my new integration or package?Version Bump?
Did I bump the version in the
pyproject.toml
file of the package I am updating? (Except for thellama-index-core
package)Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.
Suggested Checklist:
make format; make lint
to appease the lint gods