Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/fix Azure AI Search Hybrid Semantic Search Unusability due to hardcoded parameter #17683

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

edgBR
Copy link

@edgBR edgBR commented Jan 30, 2025

Description

Dear colleagues,

Currently the Azure AI Search Integration is not able to use efectively the VectorStoreQueryMode.SEMANTIC_HYBRID. This is due to the fact that the semantic config name is hardcoded in the current code. If we create the index with llama_index this is not a problem. However if we are trying to plug an play an already existing Azure AI search index that does not have the same semantic config name this will fail.

Fixes # (issue)

This fixes #17636

New Package?

Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

  • Yes
  • No

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.

  • I added new unit tests to cover this change
  • I believe this change is already covered by existing unit tests

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

Results of checklists

Tests

image

Pre-commits

image

edgBR added 2 commits January 30, 2025 23:16
…(sync and async), query methods and AzureQueryResultSearchBase derived classes to accept semantic_configuration_name as parameter
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jan 30, 2025
@edgBR edgBR changed the title Feat/fix azureaisearch integration Feat/fix Azure AI Search Hybrid Semantic Search Unusability due to hardcoded parameter Jan 30, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 31, 2025
@logan-markewich logan-markewich enabled auto-merge (squash) January 31, 2025 00:52
@edgBR
Copy link
Author

edgBR commented Jan 31, 2025

Hi @logan-markewich can you approve again? I updated with the most recent changes of the trunk.

Also, it seems I'm getting a coverage warning but I didn't add any method to a class neither any function. Can this be ignored?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Azure AI Search Hybrid Semantic Search is unusable due to hardcoded parameter
2 participants