fix: do not mutate BoolQuery instance in toArray method

[MrkMrk00]

Change the returned value of the BoolQuery::toArray method instead of mutating the instance.

Issue: #1450

[ruflin]

Thanks for opening the PR. This looks very promising as all tests pass -> nothing broke :-) Could you also add an entry to the changelog and convert this to ready for review?

Do you have any concerns on getting this in? Some side effects I'm not thinking of?

[MrkMrk00]

Hello, thanks. I wasn't sure whether to add the entry to Fixes or Change. Let me know if you want it somewhere else.

There's no side-effects that I can think of. Since _params is private, the only way I can see that someone would access it is through reflection.

Sorry for the commit from my different (work) account.

[ruflin]

Changelog LGTM. No worries about the different users for the commits. I'll squash it all together on merge. Running CI now and if all green, I'll get it in.

Should we also backport this to 7.x?

[ruflin]

Thanks for the contribution!

[MrkMrk00]

Thank you too!

Changelog LGTM. No worries about the different users for the commits. I'll squash it all together on merge. Running CI now and if all green, I'll get it in.

Should we also backport this to 7.x?

I don't see why not. Do you want me to also create a PR to the 7.x branch?

Also the issue (#1450) could probably be closed, since the original problem has been fixed.