Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Add compilation scripts for tests #17605

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kjarosh
Copy link
Member

@kjarosh kjarosh commented Aug 21, 2024

I thought I'd include the scripts I used for compiling tests. They might come in handy when editing a test in the future!

@torokati44
Copy link
Member

This is great and awesome and cool! 🥳
But ... do we need 50 of it, in a random subset of test folders? 🤔

@kjarosh
Copy link
Member Author

kjarosh commented Aug 21, 2024

This is great and awesome and cool! 🥳 But ... do we need 50 of it, in a random subset of test folders? 🤔

Well... those tests are authored in different ways, some of them are hand crafted, some of them are made in JPEXS, some of them compiled with a script, some of them made with Flash.

I added these scripts for tests that were compiled with those scripts (they were originally .gitignore'd). Additionally, not all of those 50 scripts are identical, some have different CLI options. So considering that these scripts are not identical and they are only added for tests that use them, I do not see any other option to commit them :/

@evilpie
Copy link
Collaborator

evilpie commented Aug 22, 2024

I am not going to use docker for compiling so this is just superfluous noise for me.

@Lord-McSweeney
Copy link
Collaborator

47 of them are just

docker run -it --rm -v ${PWD}:/app instrumentisto/flex-sdk mxmlc -output test.swf -compiler.debug=true Test.as

and the remaining three are the exact same command but with a SWF version specified. Sorry, but seeing as the command is mostly intuitive, and this has even more potential to confuse people (we already sometimes have Test.as, test.fla, and other files in the test folders), I don't agree with adding these.

@danielhjacobs danielhjacobs added the A-tests Area: Tests & Test Framework label Aug 27, 2024
@adrian17
Copy link
Collaborator

How about adding this docker invocation to CONTRIBUTING.md?

If there are any instructions relevant to building individual tests, I usually add them to .as (or .toml).

@danielhjacobs danielhjacobs added the T-chore Type: Chore (like updating a dependency, it's gotta be done) label Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tests Area: Tests & Test Framework T-chore Type: Chore (like updating a dependency, it's gotta be done)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants