Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

desktop: Reformat description in metainfo #17442

Closed
wants to merge 1 commit into from

Conversation

kjarosh
Copy link
Member

@kjarosh kjarosh commented Aug 9, 2024

Some stores do not ignore whitespace and newlines, treating the description as preformatted text (e.g. GNOME Software, Mintinstall).

Copy link
Collaborator

@evilpie evilpie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think I want to know how they are parsing HTML.

Some stores do not ignore whitespace and newlines, treating
the description as preformatted text (e.g. GNOME Software, Mintinstall).
@kjarosh
Copy link
Member Author

kjarosh commented Aug 9, 2024

I don't know what's going on here. When I load Ruffle metadata directly to GNOME Software as a preview, it's being parsed correctly. It's just when it gets the data from Flathub this weird parsing happens.

@kjarosh kjarosh marked this pull request as draft August 9, 2024 20:31
@kjarosh
Copy link
Member Author

kjarosh commented Aug 9, 2024

I've been checking software managers and it seems that on clean installations there's no problem with the current description. I suspect our local builds somehow influenced that.

Not to mention other apps format their descriptions the same way as us and they don't have such problems.

@danielhjacobs danielhjacobs added the A-desktop Area: Desktop Application label Aug 27, 2024
@danielhjacobs danielhjacobs added the T-chore Type: Chore (like updating a dependency, it's gotta be done) label Sep 17, 2024
@kjarosh
Copy link
Member Author

kjarosh commented Oct 8, 2024

Closing as it seems that it's an issue with the store frontend or Flathub. Other apps on Flathub and outside of it also format description the same way as us.

@kjarosh kjarosh closed this Oct 8, 2024
@kjarosh kjarosh deleted the metainfo-description branch October 8, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-desktop Area: Desktop Application T-chore Type: Chore (like updating a dependency, it's gotta be done)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants