-
-
Notifications
You must be signed in to change notification settings - Fork 938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add trusted publishers #4239
Add trusted publishers #4239
Conversation
24f9db3
to
67631fe
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4239 +/- ##
==========================================
+ Coverage 98.67% 98.71% +0.04%
==========================================
Files 306 330 +24
Lines 6889 7340 +451
==========================================
+ Hits 6798 7246 +448
- Misses 91 94 +3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots to read. Here's a first pass at the controllers mostly.
3845b91
to
00bc4cd
Compare
c16f55f
to
170448d
Compare
170448d
to
9d5d2f3
Compare
2303d50
to
a8de46f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, impressive work. I like how the controllers look now. They look much more canonical and are easier to read. I'm excited to see this feature in action.
62c19a9
to
820758f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it worked! when we are announcing and publicizing this, can we also publish a streamlined GitHub action, so our docs/examples can look something like this:
jobs:
push:
runs-on: ubuntu-latest
permissions:
contents: write
id-token: write
steps:
- uses: actions/checkout@v4
- uses: ruby/setup-ruby@v1
- uses: rubygems/release@v1
Moving all of the steps inside our first-party action also means that we can update the code that our clients are running if necessary.
app/views/components/oidc/trusted_publisher/github_action/form_component.rb
Outdated
Show resolved
Hide resolved
820758f
to
89a8202
Compare
For now, only supports GH Actions. Guides in rubygems/guides#348. Heavily inspired by PyPi's trusted publisher feature (https://docs.pypi.org/trusted-publishers/).
UI demo:

https://docs.google.com/document/d/1iJBiH4xSx9ZqvwQpeWu8fzb8UjrwV3Ta7M7azXKtJhA/edit?usp=sharing