Reduce unnecessary external state assignment (singleton)
#1312
+42
−72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
approved these changes
Mar 14, 2025
| @@ -289,18 +289,16 @@ def handle_meta_method_comment(comment, node) | |||
|
|
|||
| if attributes | |||
| attributes.each do |attr| | |||
| a = RDoc::Attr.new(@container, attr, rw, processed_comment) | |||
| a = RDoc::Attr.new(@container, attr, rw, processed_comment, singleton: @singleton) | |||
There was a problem hiding this comment.
I know these aren't a part of this PR, but I would really like us to avoid naming variables as a 😅.
Maybe alias_entry or alias_object?
There was a problem hiding this comment.
Agreed. I'll open a separate PR to expand these short variable names 👍
Co-authored-by: Vinicius Stock <[email protected]>
Deploying rdoc with
|
| Latest commit: |
7a8045f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://325cef31.rdoc-6cd.pages.dev |
| Branch Preview URL: | https://refactor-code-object-constru.rdoc-6cd.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It really bugs me that RDoc has a tendency of assigning a state through a setter immediately after the object's initialization. This makes the dependencies unclear and code unnecessarily verbose.
I'm taking a first step to fix the pattern by passing
singletonas a constructor argument whenever possible.