Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install things as necessary from shinycoreci r-universe #260

Merged
merged 75 commits into from
May 17, 2024
Merged
Changes from 1 commit
Commits
Show all changes
75 commits
Select commit Hold shift + click to select a range
74ab363
First pass at installing less things and install apps deps on demand …
schloerke Mar 12, 2024
1ea2d11
Code feedback
schloerke Mar 12, 2024
7509a52
checks
schloerke Mar 12, 2024
b58c1f2
Use `resolve_libpath(local_pkgs=)` for clearer intent
schloerke Mar 12, 2024
f430f2c
Use `actions/checkout@v4`, not `@v3`
schloerke Mar 12, 2024
35f3822
Remove install step
schloerke Mar 12, 2024
c055d24
Restructure matrix to be a shotgun
schloerke Mar 12, 2024
d7b613a
Remove slack integration
schloerke Mar 12, 2024
700ec5d
fix snaps
schloerke Mar 13, 2024
0436cf8
Fix readme
schloerke Mar 13, 2024
642c336
Add app to proove that pkgs are installed
schloerke Mar 13, 2024
38dc962
Add `attempt_to_install_universe()` method
schloerke Mar 13, 2024
582c8ae
Use new shinyverse install method
schloerke Mar 13, 2024
ba35e56
Generate apps deps (GitHub Actions)
schloerke Mar 13, 2024
4487d9b
Fix broken test
schloerke Mar 14, 2024
25c8744
fix snaps
schloerke Mar 14, 2024
c89ecda
Update step dep to remove node16 warning
schloerke Mar 14, 2024
1703e7a
Remove `gha-adjust-packages-to-install.R` script
schloerke Mar 14, 2024
a972c29
Update apps-test-os.yml
schloerke Mar 14, 2024
63a6511
Suppress output when installing first time in test_in_local
schloerke Mar 14, 2024
be8fb26
Diagnostics
schloerke Mar 14, 2024
10f6fa5
Try custom installation of shinyverse
schloerke Mar 14, 2024
6ba6fef
Generate apps deps (GitHub Actions)
schloerke Mar 14, 2024
52e9bae
Make the shinyverse the first cran repo. Add rspm afterwards
schloerke Mar 14, 2024
e7f5d7a
Merge branch 'install_all_the_things' of https://github.com/rstudio/s…
schloerke Mar 14, 2024
7888dc6
Update action.yaml
schloerke Mar 14, 2024
a39b86c
Update action.yaml
schloerke Mar 14, 2024
767786b
Do not install to new lib on CI; Avoid full double installation of co…
schloerke Mar 14, 2024
47c8ca1
Remove unused files
schloerke Mar 14, 2024
2a7f84c
Fix typo
schloerke Mar 14, 2024
dcb1dd4
Get info from r-universe directly
schloerke Mar 14, 2024
34ef83b
Generate apps deps (GitHub Actions)
schloerke Mar 14, 2024
40474b1
Bump version
schloerke Mar 14, 2024
c7b8dc7
`devtools::build_readme()` (GitHub Actions)
schloerke Mar 14, 2024
7f3a76e
Try forcing an upgrade to install the pkgs
schloerke Mar 14, 2024
e4e2c34
Try installing the shinyverse from source at start
schloerke Mar 14, 2024
ec4d0f9
On ci, store packages in side lib
schloerke Mar 14, 2024
885a62b
Install proper rtools version
schloerke Mar 14, 2024
d19b0c8
Use helper method to find shinyverse recursive deps (e.g. `httpuv`) w…
schloerke Mar 14, 2024
7fe88c0
Install shinycoreci R package from RSPM; Let shinycoreci handle shiny…
schloerke Mar 14, 2024
e9401a5
Update action.yaml
schloerke Mar 14, 2024
d2e23dc
Remove CI test
schloerke Mar 14, 2024
be655aa
Remove check warning
schloerke Mar 14, 2024
799a6d7
Merge branch 'main' into install_all_the_things
schloerke Mar 14, 2024
fe58f92
Generate apps deps (GitHub Actions)
schloerke Mar 14, 2024
6c0b79a
Touch >=10 apps so many apps are tested
schloerke Mar 15, 2024
c9e10a3
Merge branch 'install_all_the_things' of https://github.com/rstudio/s…
schloerke Mar 15, 2024
1dfbca3
Generate apps deps (GitHub Actions)
schloerke Mar 15, 2024
f5ef9f9
Try to inspect more of the shiny packages when installing. Make sure …
schloerke Mar 15, 2024
1b76fba
Sort order the shinyverse
schloerke Mar 15, 2024
42db712
Try installing mac sys deps before installing R
schloerke Mar 15, 2024
adceeb4
Add shinycoreci to the mix of packages to be installed; e.g. 316 need…
schloerke Mar 15, 2024
a005a00
Update action.yaml
schloerke Mar 15, 2024
1456238
Update action.yaml
schloerke Mar 15, 2024
e996e77
Update action.yaml
schloerke Mar 15, 2024
c6a4961
Remove macos brew installs for now
schloerke Mar 15, 2024
8557cf2
Reduce install timeout
schloerke Mar 15, 2024
49c2b03
Make withr an Import
schloerke Mar 15, 2024
2e77a06
Only install shinycoreci if the libpath is shinycoreci_libpath
schloerke Mar 15, 2024
6d6c703
Update DESCRIPTION
schloerke Mar 15, 2024
4a29501
Merge branch 'main' into install_all_the_things
cpsievert Apr 1, 2024
847be9b
Generate apps deps (GitHub Actions)
cpsievert Apr 1, 2024
2725925
Undo changes to snapshots (they're just for experimenting)
cpsievert Apr 1, 2024
ab4b3a3
Remove rtools version for windows. Let shiny-workflows handle it
schloerke Apr 1, 2024
572d7b4
Use `3.x` for pandoc version; (Upgrading from 2.7.3)
schloerke Apr 1, 2024
2a3f873
match padoc-version for install to 3.x
schloerke Apr 1, 2024
d4b3228
Merge branch 'main' into install_all_the_things
cpsievert May 17, 2024
05eda24
Apply suggestions from code review
cpsievert May 17, 2024
d4ec97c
`devtools::build_readme()` (GitHub Actions)
cpsievert May 17, 2024
0e47d2c
Apply suggestions from code review
cpsievert May 17, 2024
68d6f4c
Use regular installation methods
cpsievert May 17, 2024
f32501a
Apply suggestions from code review
schloerke May 17, 2024
fdefb69
`devtools::document()` (GitHub Actions)
schloerke May 17, 2024
c396ae1
`devtools::build_readme()` (GitHub Actions)
schloerke May 17, 2024
ab9c589
Missed one
cpsievert May 17, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update action.yaml
schloerke committed Mar 15, 2024
commit 145623824dd325560c1e36ea2423ee72cf7293ed
2 changes: 0 additions & 2 deletions .github/internal/install-shinyverse/action.yaml
Original file line number Diff line number Diff line change
@@ -63,8 +63,6 @@ runs:
- name: Install macOS brew dependencies for all apps
uses: shiny-workflows/setup-macOS-dependencies@v1
if: ${{ runner.os == 'macOS' }}
# something other than `.`
working-directory: R
with:
extra-packages: |
${{ steps.app-deps.outputs.pkgs }}