Implements $cancel()
method for ExtendedTask
#4199
Draft
+40
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4093.
Adds a
$cancel()
method toExtendedTask
, analogous to the python implementation.This keeps it simple, and is straightforward as the
do.call()
in the code creates the task object anyway, and we just need to store it in a private field.Previously I'd thought that the promise itself might have a
$cancel
method, but looking at javascript promises, this actually doesn't exist. It's also not natural to implement it that way, aspromises::promise()
takes functions as arguments, rather than the task object itself. We'd most likely need to rely on eachas.promise()
method to create this.We could make cancellation extendable via a S3 generic for the task object for example, but as mirai is the only known implementation with cancellation capability thus far, we might defer this.