-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No longer import sp by default #942
Conversation
Also require shiny 1.0 (since it is old and can help remove a workaround
Given #928 and
From https://github.com/rspatial/terra
It's a welcome change! |
Thanks for the quick review @schloerke ! I addressed your comments I reverted everything related to terra / raster as I plan to take this on in a future PR.
|
Thank you @olivroy ! (I'll merge once the checks pass. Thank you for the separation of PRs regarding raster/terra) |
The goal of this PR is to reduce the number of imports by removing the sp package eventually.
Now that sp imports sf and raster imports terra, it would be great if leaflet normalized objects to terra.
Before this PR, an sp object would get normalized inside leaflet, but since sp uses sf under the hood, it is better to just convert to sf in leaflet, so that it can use a common leaflet logic and leave the normalization to sf instead of having custom methods in leaflet.
I plan to replace raster usage by terra, but I will wait to see if there is appetite in leaflet for that kind of change.
Since raster and sp objects are more and more obsolete, it seems odd that leaflet continues to import these packages unconditionnally as they are used less and less nowadays.