Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build for Ruby 3.4.0 preview 1 #1581

Merged
merged 2 commits into from
Jul 14, 2024
Merged

Fix build for Ruby 3.4.0 preview 1 #1581

merged 2 commits into from
Jul 14, 2024

Conversation

JonRowe
Copy link
Member

@JonRowe JonRowe commented Jul 13, 2024

Ruby head is currently Ruby 3.4 and has a couple of changes which issue warnings this PR:

  • Removes some warnings about block paramters being unused, even though ironically, they are
  • Relaxes some checks around formatting

@JonRowe
Copy link
Member Author

JonRowe commented Jul 14, 2024

Cucumber is failing on head potentially because of hash changes? I'm going to merge this and I will probably add a 3.4.0-preview1 matrix entry

@JonRowe JonRowe merged commit fe4d292 into main Jul 14, 2024
29 of 30 checks passed
@JonRowe JonRowe deleted the fix-ruby-head branch July 14, 2024 07:49
JonRowe added a commit that referenced this pull request Jul 16, 2024
Fix build for Ruby 3.4.0 preview 1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant