-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrates to vite@6
to drop base64 inlined worker source from all bundles
#1637
base: master
Are you sure you want to change the base?
Migrates to vite@6
to drop base64 inlined worker source from all bundles
#1637
Conversation
Without this change, build would fail because the produced stylesheet assumes the `package.json['name']` i.e., `styles/rrweb.css`. To maintain the existing behavior, these changes are required. See https://vite.dev/guide/migration.html#customize-css-output-file-name-in-library-mode
vite@6
to drop base64 inlined worker source from all bundles
Thanks for taking your time to upgrade vite Rui!
Edit: I take this back, I hadn't read the code changes in vite 6, this will totally fix the issue, and I'm happy to put in the time to get this over the finish line. |
🦋 Changeset detectedLatest commit: 24af677 The changes in this PR will be included in the next version bump. This PR includes changesets to release 19 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
👀 |
@ruiconti @Juice10 @pauldambra When did this one merge? |
🙏 |
Investigation: #1578 (comment)
Motivation: #1568 (comment)
Opening this tentatively to see if there's interest in merging this, so consumers don't have to rely on patches to fix this issue. If there is, happy to comply with all the contributing guidelines, rebases to
master
, etc.Resolves #1578