Migrates to vite@6 to drop base64 inlined worker source from all bundles
#1637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this change, build would fail because the produced stylesheet assumes the `package.json['name']` i.e., `styles/rrweb.css`. To maintain the existing behavior, these changes are required. See https://vite.dev/guide/migration.html#customize-css-output-file-name-in-library-mode
1 task
ruiconti
changed the title
vite@6 to drop base64 inlined worker source from all bundles
|
Thanks for taking your time to upgrade vite Rui! Edit: I take this back, I hadn't read the code changes in vite 6, this will totally fix the issue, and I'm happy to put in the time to get this over the finish line. |
🦋 Changeset detectedLatest commit: 24af677 The changes in this PR will be included in the next version bump. This PR includes changesets to release 19 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
👀 |
|
@ruiconti @Juice10 @pauldambra When did this one merge? |
|
🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Investigation: #1578 (comment)
Motivation: #1568 (comment)
Opening this tentatively to see if there's interest in merging this, so consumers don't have to rely on patches to fix this issue. If there is, happy to comply with all the contributing guidelines, rebases to
master, etc.Resolves #1578