improvements to <link rel="stylesheet"> + mutations #1483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: def3730 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
eoghanmurray
force-pushed
the
stylesheet-preload
branch
from
a599265
to
d61237e
Compare
… checking the replay took me ages to debug as I thought it was something I introducedg
… mutations with `absoluteToStylesheet` - I had accidentally removed that with initial work
…yStylesheet to happen in a single place during initial snapshot.
…tyle> need to be tracked
…n't being assigned to correct text node, and provide remedy whereby css text is properly re-split upon rebuild
…our there and some explanatory comments
…hat the css hasn't been altered server-side/in-transit
… second text child instead of the first
…ion, even if there is only one text element on the <style>. Recent conversation with Justin has firmed up my thinking on why we look at .sheet in the first place (it's not because we want to get rid of vendor prefixes, which may actually be undesirable where they are useful for accurate replay in the replayer - but rather it's to ensure we don't miss any programmatic style mutations that have happened - have added comments to reflect this)
rrweb:test: test/utils.ts:181:43 - error TS2345: Argument of type 'elementNode & { rootId?: number | undefined; isShadowHost?: boolean | undefined; isShadow?: boolean | undefined; } & { id: number; }' is not assignable to parameter of type '{ attributes: { src?: string | undefined; }; }'.
rrweb:test: Types of property 'attributes' are incompatible.
rrweb:test: Type 'attributes' has no properties in common with type '{ src?: string | undefined; }'.
rrweb:test:
rrweb:test: 181 stripBlobURLsFromAttributes(add.node);
…red twice after a mutation to rel="stylesheet" from rel="preload"
…o rrweb/src/record/asset-manager.ts - no need to re-serialize the <link> element; we are only interested in the css contents after it loads - add a mutation event with the new css contents if the href is updated and a new stylesheet loads in - don't emit two mutation events for the rel="preload" case; we only need the onload event after it becomes rel="stylesheet"
… of looking at config
…oad event ... what if the load event has already fired in some browsers (or if the mutation event is delayed)
eoghanmurray
force-pushed
the
stylesheet-preload
branch
from
1c90d6c
to
def3730
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This PR (by necessity) builds on top of #1437
existing code special cased rel="preload" so that a subsequent attribute mutation from rel="preload" -> rel="stylesheet" would get picked up.
New code deals with any attribute mutation which results in us 'now having a stylesheet link'
as well as completing the TODO for when a stylesheet link href gets updatd