Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added dual_laser_merger #43365

Merged
merged 2 commits into from
Nov 12, 2024
Merged

added dual_laser_merger #43365

merged 2 commits into from
Nov 12, 2024

Conversation

pradyum
Copy link
Contributor

@pradyum pradyum commented Nov 6, 2024

Please Add This Package to be indexed in the rosdistro.

dual_laser_merger

The source is here:

https://github.com/pradyum/dual_laser_merger

Checks

  • All packages have a declared license in the package.xml
  • This repository has a LICENSE file
  • This package is expected to build on the submitted rosdistro

@github-actions github-actions bot added humble Issue/PR is for the ROS 2 Humble distribution jazzy Issue/PR is for the ROS 2 Jazzy distribution rolling Issue/PR is for the ROS 2 Rolling distribution labels Nov 6, 2024
Copy link
Member

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

name is generic, but the package looks general purpose to me

lgtm, but waiting for a second reviewer

@christophebedard
Copy link
Member

  • At least one of the following must be present
    • Top level license file:
    • Per package license files:
  • License is OSI-approved:
  • License correctly listed in package.xmls
  • Public source repo:
  • Source repository contains ROS packages
  • Each package meets REP-144 naming conventions

I agree it's pretty generic, but it describes what it does.


There's an unrelated CI failure that I believe should be fixed by #43359. Can you rebase on your branch on this repo's master branch?

@pradyum
Copy link
Contributor Author

pradyum commented Nov 12, 2024

I have updated updated the master branch

@christophebedard
Copy link
Member

Thank you, now CI passes!

@christophebedard christophebedard merged commit 93cff5f into ros:master Nov 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
humble Issue/PR is for the ROS 2 Humble distribution jazzy Issue/PR is for the ROS 2 Jazzy distribution rolling Issue/PR is for the ROS 2 Rolling distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants