Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hri_face_body_matcher: 2.0.3-1 in 'humble/distribution.yaml' [bloom] #42871

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

severin-lemaignan
Copy link
Contributor

@severin-lemaignan severin-lemaignan commented Sep 16, 2024

Import package(s) in repository hri_face_body_matcher 2.0.3-1:

hri_face_body_matcher

hri_face_body_matcher is a ROS4HRI -compliant node that attempts to match people faces to their detected bodies.

Check here for the complete CHANGELOG.

@github-actions github-actions bot added the humble Issue/PR is for the ROS 2 Humble distribution label Sep 16, 2024
@sloretz sloretz added the held for sync Issue/PR has been held because the distribution is in a sync hold label Sep 17, 2024
@sloretz
Copy link
Contributor

sloretz commented Sep 17, 2024

Holding for Humble sync

@audrow audrow removed the held for sync Issue/PR has been held because the distribution is in a sync hold label Sep 19, 2024
@audrow
Copy link
Contributor

audrow commented Sep 25, 2024

I'm not sure if we should accept this because of the license. Asking...

@audrow audrow added the more information needed Maintainers have asked for additional information label Sep 25, 2024
@audrow
Copy link
Contributor

audrow commented Sep 25, 2024

Hey @severin-lemaignan, we can't accept that license on the buildfarm. If you can change it to a common open source license, we can accept it.

@audrow audrow added changes requested Maintainers have asked for changes to the pull request and removed more information needed Maintainers have asked for additional information labels Sep 25, 2024
Copy link
Member

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't have an OSI approved license which allows us to redistribute it freely to the community.

For reference LICENSE: https://github.com/ros4hri/hri_face_body_matcher/blob/humble-devel/LICENSE

@methylDragon
Copy link
Contributor

@severin-lemaignan bump.

You should change the LICENSE to an open-source one found https://opensource.org/licenses (preferably one of the "Popular licenses").

Copy link

This PR hasn't been activity in 14 days. If you are still are interested in getting it merged please provide an update. Otherwise it will likely be closed by a rosdistro maintainer following our contributing policy. It's been labeled "stale" for visibility to the maintainers. If this label isn't appropriate, you can ask a maintainer to remove the label and add the 'persistent' label.

@github-actions github-actions bot added the stale Issue/PR hasn't been active in a while and may be closed. label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes requested Maintainers have asked for changes to the pull request humble Issue/PR is for the ROS 2 Humble distribution stale Issue/PR hasn't been active in a while and may be closed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants