Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downsampling in calibrator.py makes detection fail #589

Open
martimorta-at-work opened this issue Aug 21, 2020 · 2 comments
Open

Downsampling in calibrator.py makes detection fail #589

martimorta-at-work opened this issue Aug 21, 2020 · 2 comments

Comments

@martimorta-at-work
Copy link

Hi,
I was having issues detecting a checkerboard until I changed the downsampling size (below) from VGA for the actual size of the camera output.

scale = math.sqrt( (width*height) / (640.*480.) )

I think having that as a parameter would allow better calibrations unless I am missing something here.
I am happy to submit a PR with VGA size being a parameter if there aren't other implications.

Cheers!

@JWhitleyWork
Copy link
Collaborator

@martimorta-at-work I know it's going on almost a year since you submitted this but we would be happy to accept a PR with this.

@onurtore
Copy link

@JWhitleyWork,
Still interested? I can create a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants