-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supports Ruby 3.0, Oauth2 2.0 , JWT 2.9.3 #35
base: master
Are you sure you want to change the base?
Conversation
regismesquita
commented
Oct 7, 2024
•
edited
Loading
edited
- Ruby 3.0 and oauth2 support
- JWT 2.9.3 update
- Fixes multiple rubocop complaints and disable cop
- Updates reek and rubocop for fixing requirements
- Major version update
Still working on updating JWT to ~> 2.9.3 |
Need to test some stuff internally but seems to be working as expected now. |
Hi, @blacksam07 and @TimoPeraza, tagging you here as the most recent committers in case the CODEOWNERS file isn’t current. Appreciate any input you can provide! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for your contributions
@@ -2,6 +2,7 @@ | |||
|
|||
module AppleAuth | |||
module Base | |||
VERSION = '1.1.0' | |||
# Updated major version as the gem is now compatible with Ruby 3.0 and OAuth2 2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove this comment and include it in the release notes
# Apple seems to expect the auth_scheme to be on | ||
# the body, the default is :basic_auth |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove this comments and include an explain in the readme file that now we already add the auth_schema
in the body
Hi @regismesquita Thanks for you contribution is a great job, we will check the removal of support for older versions of Ruby and how we can continue with these changes. |