Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supports Ruby 3.0, Oauth2 2.0 , JWT 2.9.3 #35

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

regismesquita
Copy link

@regismesquita regismesquita commented Oct 7, 2024

  • Ruby 3.0 and oauth2 support
  • JWT 2.9.3 update
  • Fixes multiple rubocop complaints and disable cop
  • Updates reek and rubocop for fixing requirements
  • Major version update

@regismesquita regismesquita requested a review from santib as a code owner October 7, 2024 15:52
@regismesquita regismesquita marked this pull request as draft October 7, 2024 16:29
@regismesquita
Copy link
Author

Still working on updating JWT to ~> 2.9.3

@regismesquita regismesquita marked this pull request as ready for review October 8, 2024 14:08
@regismesquita
Copy link
Author

Need to test some stuff internally but seems to be working as expected now.

@regismesquita regismesquita changed the title update oauth Supports Ruby 3.0, Oauth2 2.0 , JWT 2.9.3 Oct 8, 2024
@regismesquita
Copy link
Author

Hi, @blacksam07 and @TimoPeraza, tagging you here as the most recent committers in case the CODEOWNERS file isn’t current. Appreciate any input you can provide!

Copy link
Contributor

@blacksam07 blacksam07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contributions

@@ -2,6 +2,7 @@

module AppleAuth
module Base
VERSION = '1.1.0'
# Updated major version as the gem is now compatible with Ruby 3.0 and OAuth2 2.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove this comment and include it in the release notes

Comment on lines +78 to +79
# Apple seems to expect the auth_scheme to be on
# the body, the default is :basic_auth
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove this comments and include an explain in the readme file that now we already add the auth_schema in the body

@blacksam07 blacksam07 requested a review from antoalconti October 9, 2024 14:21
@blacksam07
Copy link
Contributor

Hi, @blacksam07 and @TimoPeraza, tagging you here as the most recent committers in case the CODEOWNERS file isn’t current. Appreciate any input you can provide!

Hi @regismesquita Thanks for you contribution is a great job, we will check the removal of support for older versions of Ruby and how we can continue with these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants