Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add trellis version option for new command #140

Merged
merged 1 commit into from
Nov 13, 2020
Merged

Add trellis version option for new command #140

merged 1 commit into from
Nov 13, 2020

Conversation

swalkinshaw
Copy link
Member

@swalkinshaw swalkinshaw commented Nov 13, 2020 •
edited
Loading

Closes #138

--trellis-version accepts:

  • latest
  • dev (HEAD/master)
  • or any version/tag

Example:

$ trellis new --trellis-version=1.7.0 example.com

tangrufus
tangrufus approved these changes Nov 13, 2020
View reviewed changes
Copy link
Collaborator

@tangrufus tangrufus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🎉

@swalkinshaw
Add trellis version option for new command
6779524 
`--trellis-version` accepts:
- `latest`
- `master`
- or any version/tag

Example:

```bash
$ trellis new --trellis-version=1.7.0 example.com
```
@swalkinshaw
Copy link
Member Author

I went with dev as the option name for master/HEAD

@swalkinshaw swalkinshaw merged commit f17dd81 into master Nov 13, 2020
@swalkinshaw swalkinshaw deleted the add-trellis-version-option branch November 13, 2020 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangrufus tangrufus tangrufus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Define Trellis Release
2 participants
@swalkinshaw @tangrufus