Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify and update requirements of the async-race task #1765

Merged
merged 4 commits into from
Mar 24, 2025

Conversation

zagorky
Copy link
Contributor

@zagorky zagorky commented Mar 16, 2025

Title of Pull Request

🤔 This is a ...

  • 🌟 New task
  • 🌐 New module
  • ⚙️ Update to an existing task
  • 🔧 Update to an existing module
  • 🔗 Update or addition of external resources or links
  • 🐛 Fix in a task or related content
  • 🛠 Fix in a module or related content
  • ✏️ Fixed a typo or grammatical error
  • 🔗 Fixed a broken link
  • ❓ Other (specify: ****____****)

Description

  • Brief Overview:

Update requirements due to Airbnb style guide incompatibility, clarify allowed CSS libraries, and restrict type assertions.

  • Implementation Approach:
  1. Replace Airbnb style guide with Unicorn style guide;
  2. Define allowed CSS libraries;
  3. Restrict type assertions and non-nullable type assertions;

Additional Information

  • Screenshots/Links:
  • Related Issues:

Checklist

  • ✅ I have performed a self-review of my own code.
  • 📝 I have commented my code, particularly in hard-to-understand areas.
  • 🔧 I have made corresponding changes to the documentation (if applicable).
  • 🚫 My changes generate no new warnings or errors.

Copy link
Collaborator

@stardustmeg stardustmeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, run prettier for us to have consistent formatting in the school materials 🤗

@stardustmeg stardustmeg merged commit b2c50df into rolling-scopes-school:master Mar 24, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants