Skip to content

Commit

Permalink
add readme for milestone 2
Browse files Browse the repository at this point in the history
  • Loading branch information
rohit1101 authored Jul 8, 2024
1 parent 4e00385 commit 3a6a1f5
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,7 @@ docker build -t <docker-hub-repo-name>/<image-name>:<tag-name>v1.0
docker push <docker-hub-repo-name>/<image-name>:<tag-name>v1.0
```

- To execute `make containerise` to pull the image from docker registry and create a `web-server` container make sure your provide your Docker Hub repo name and image with the desired tag.
- To execute `make containerise` to pull the image from docker registry and create a `web-server` container make sure your provide your Docker Hub repo name and image with the desired tag. Please refer the command [here](https://github.com/rohit1101/SRE-Bootcamp-Web-Server/blob/milestone-2/Makefile#L26)
- **NOTE: In the above Dockerfile I have directly passed a environment variables but in production environment it is better to use Docker secrets.**

---
Expand Down

0 comments on commit 3a6a1f5

Please sign in to comment.