feat(test): move from cypress to playwright #64
Conversation
roedoejet
force-pushed
the
dev.playwright
branch
6 times, most recently
from
27933eb
to
2737b65
Compare
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
joanise
force-pushed
the
dev.playwright
branch
from
5f60a2c
to
d3c6144
Compare
| - name: Install Playwright Browsers | ||
| run: npx playwright install --with-deps | ||
| - name: Run Playwright tests | ||
| run: npx npm run-script e2e |
There was a problem hiding this comment.
npx should not be needed here.
There was a problem hiding this comment.
Oh, and I finally read the manual: npm run is an alias for npm run-script, as are npm rum and npm urn. LOL. I guess they try to cover what people might type. run is certainly
a convenient alias, but it's kinda silly to let actual typos works...
| @@ -1,3 +1,2 @@ | |||
| package-lock.json | |||
There was a problem hiding this comment.
I just removed this line and force pushed a change to undo the indent toggle on package-lock.json. See Slack for details. Having prettier format package-lock.json too should stop this indent toggle.
I think I like playwright more than Cypress. On first glance it seems easier to configure and it's nice that we can use it for both our TypeScript and Python projects. I don't really understand how we're supposed to integrate the coverage checking into the tests (despite reading most of this awful, long issue), but it does appear to work, so that seems to be an improvement over cypress.