Do not re-cycle the outline in strict mode #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
|
(I'm trying to merge. Github is giving me a bizarre error. I'll try again in a bit.) |
|
Tests are failing because Python 3.7 is dead meat. |
|
Fixed and merged. |
|
For some reason pushing the tag didn't create a pypi release; looking into this but if anyone sees what went wrong, will be thankful |
|
Ok, now updated and pushed to pypi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FontMath currently moves the off-curves of a contour from the beginning to the end while doing math on a glyph. The upshot of this is that, even in "strict" mode, the output contours are not compatible with the input contours. This means you can't add instances as masters to an interpolation, which seems a needless restriction.