-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ✨ from_easyocr detection added #1515
Conversation
Signed-off-by: Onuralp SEZER <[email protected]>
Signed-off-by: Onuralp SEZER <[email protected]>
0ed3e52
to
16e3578
Compare
1c32eb6
to
c187365
Compare
Hi @onuralpszr 👋 It turns out, this isn't the first instance of OCR we have in It uses the The question is whether we should change that, match it or ignore it. I suggest we change |
refactor: ♻️ update text data field to CLASS_NAME_DATA_FIELD in config and detection modules to reduce complexity of datafield names Signed-off-by: Onuralp SEZER <[email protected]>
c187365
to
1a870b9
Compare
Based on conversation we made with @LinasKo, I decided to reduce complexity and doing a way without creating "deprecated" type I went for "class_name" that so it will match "CLASS_NAME_DATA_FIELD" and we don't need to change Florance-2 side as well. |
9b30b8b
to
47a7f92
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified the docs, verified the results run in Colab (with color_lookup=sv.ColorLookup.INDEX
added to each annotator). Going to check for regression in NCNN just in case.
097f9e6
to
7c7599a
Compare
7c7599a
to
943a214
Compare
Thanks @onuralpszr! Merging this, after a few miniscule changes. |
Description
EasyOCR detections added.
How has this change been tested, please provide a testcase or example of how you tested the change?
Google Collab: https://colab.research.google.com/drive/1GAFuDZwXrxWY0O6M8K8sGdmvNoc9R5i5?usp=sharing
Docs
Example Results