Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numpy upper limit: <2.0.0 #1288

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Numpy upper limit: <2.0.0 #1288

merged 1 commit into from
Jun 17, 2024

Conversation

LinasKo
Copy link
Collaborator

@LinasKo LinasKo commented Jun 17, 2024

Description

As of a few days ago, an error is raised when attempting to load cv2, as it does not support numpy 2.0.0. This results in our CI tests failing and may have consequences for end-users.

Until all our dependencies expand support, let's pin numpy to <2.0.0.

See more: opencv/opencv-python#943 (comment)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How has this change been tested, please provide a testcase or example of how you tested the change?

  1. pytest passes
  2. poetry install --with dev works
  3. Verified that changes to the lock file are minimal
  4. importing cv2 and numpy work
  5. Hopefully CI builds succeeds, unlike in ⬆️ Bump ruff from 0.4.8 to 0.4.9 #1286

Any specific deployment considerations

I have not done anything with respect to versioning. We should think about releasing this as 0.21.1.

Docs

@LinasKo LinasKo requested a review from SkalskiP June 17, 2024 14:29
@onuralpszr
Copy link
Collaborator

I am merging now for keep dev workable.

@onuralpszr onuralpszr merged commit 246b8a7 into develop Jun 17, 2024
10 checks passed
@LinasKo
Copy link
Collaborator Author

LinasKo commented Jun 17, 2024

I think it's a good decision to merge quickly this time; thanks @onuralpszr!

Though for anything larger (even if urgent), let's add some time for a core team to get a second opinion 😉

@onuralpszr
Copy link
Collaborator

I think it's a good decision to merge quickly this time; thanks @onuralpszr!

Though for anything larger (even if urgent), let's add some time for a core team to get a second opinion 😉

Thanks, For this one. I had to make sure dev is alive and for actual solution we need to find abi friendly way handling it for 1.x and 2.x if possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants