project.py fixes for uploading hosted images #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two small changes: (1) When passing in a URL (for hosted image)'self.check_valid_image(path)' doesn't need to run, so we put 'is_hosted' before in the 'or' statement. (2) When pushing to the API for upload, we had 'self.project_name' which doesn't exists. It should be 'project_name' which is calculated a few lines prior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two small changes:
(1) When passing in a URL (for hosted image)'self.check_valid_image(path)' doesn't need to run, so we put 'is_hosted' before in the 'or' statement. (2) When pushing to the API for upload, we had 'self.project_name' which doesn't exists. It should be 'project_name' which is calculated a few lines prior.
Description
Hosted image upload was failing. I fixed 2 things:
(1) When passing in a URL (for hosted image)'self.check_valid_image(path)' doesn't need to run, so we put 'is_hosted' before in the 'or' statement. (2) When pushing to the API for upload, we had 'self.project_name' which doesn't exists. It should be 'project_name' which is calculated a few lines prior.
Type of change
How has this change been tested, please provide a testcase or example of how you tested the change?
Running an upload via python for a hosted image:
project.upload("https://jacketmediaco.com/wp-content/uploads/2016/02/GoogleTruck.jpg", hosted_image=True)
Any specific deployment considerations
None. I don't think many people used this because It didnt work.
Docs
I will be updating the roboflow docs: https://docs.roboflow.com/datasets/adding-data/upload-data-from-aws-gcp-and-azure