Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix prediction parameter name #169

Merged
merged 2 commits into from
Aug 23, 2023
Merged

fix prediction parameter name #169

merged 2 commits into from
Aug 23, 2023

Conversation

tonylampada
Copy link
Collaborator

@tonylampada tonylampada commented Aug 23, 2023

Description

Uploading annotations takes an optional parameter is_prediction, which had an innocuos effect as it was being passed with the wrong name to the actual backend API

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How has this change been tested, please provide a testcase or example of how you tested the change?

Tested locally
context - https://roboflow.slack.com/archives/C02KWK9U8PQ/p1692816353862449?thread_ts=1692756384.477109&cid=C02KWK9U8PQ

Any specific deployment considerations

Will need a new release

@tonylampada tonylampada marked this pull request as ready for review August 23, 2023 18:52
Copy link
Contributor

@paulguerrie paulguerrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tonylampada tonylampada merged commit 4f0fa63 into main Aug 23, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants