Adding verbosity option in version downloads #166
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stellasphere Great work! One thing that comes to mind is that @paulguerrie @yeldarby Should we remove |
Yes! I'm for that. |
|
@stellasphere Do you want to take on that change? |
|
@stellasphere I have written a PR for removing |
|
The PR to remove |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #164 by adding a verbosity customization
verboseoption to theversion.download()function. The default is set to true, and thus will not affect any users not wishing to disable verbose outputs.Type of change
Please delete options that are not relevant.
How has this change been tested, please provide a testcase or example of how you tested the change?
Yes. Tested version downloads with the verbose option set true, false, and unset and performed as expected.
Also tested the entire traditional export code snippet from the Roboflow UI, performed as expected with no changes to behavior.
Any specific deployment considerations
None
Docs
Added info on the verbose option