Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding verbosity option in version downloads #166

Closed
wants to merge 2 commits into from

Conversation

stellasphere
Copy link
Contributor

Description

Fixes #164 by adding a verbosity customization verbose option to the version.download() function. The default is set to true, and thus will not affect any users not wishing to disable verbose outputs.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How has this change been tested, please provide a testcase or example of how you tested the change?

Yes. Tested version downloads with the verbose option set true, false, and unset and performed as expected.

Also tested the entire traditional export code snippet from the Roboflow UI, performed as expected with no changes to behavior.

Any specific deployment considerations

None

Docs

  • Docs updated? What were the changes:
    Added info on the verbose option

@capjamesg
Copy link
Collaborator

@stellasphere Great work! One thing that comes to mind is that wget may be redundant.

@paulguerrie @yeldarby Should we remove wget altogether and use requests? I don't see what benefit this additional dependency brings.

@paulguerrie
Copy link
Contributor

@stellasphere Great work! One thing that comes to mind is that wget may be redundant.

@paulguerrie @yeldarby Should we remove wget altogether and use requests? I don't see what benefit this additional dependency brings.

Yes! I'm for that.

@capjamesg
Copy link
Collaborator

@stellasphere Do you want to take on that change?

@capjamesg
Copy link
Collaborator

@stellasphere I have written a PR for removing wget: https://github.com/roboflow/roboflow-python/pulls

@capjamesg
Copy link
Collaborator

The PR to remove wget has been merged (#179). This will resolve the verbosity issue.

@capjamesg capjamesg closed this Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verbosity causing IO issues in Kaggle
3 participants