-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make uploading large datasets more robust #162
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonylampada
changed the title
defend against error when converting http response to json
Make uploading large datasets more robust
Aug 15, 2023
probicheaux
approved these changes
Aug 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
if response.status_code == 200: | ||
if responsejson: | ||
if "duplicate" in responsejson.keys(): | ||
print(f"Duplicate image not uploaded: {image_path}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe should be warning or info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #163
The upload API may sometimes have some hiccups giving 502 errors with some html in the response.
The pip package handles errors, but doing
response.json()
when handling an error will itself throw an error, and that can break uploading a big dataset.This PR makes uploading more robust when using
workspace.upload_dataset
Type of change
How has this change been tested, please provide a testcase or example of how you tested the change?
Uploaded big dataset using a snippet like
testupload.py
Obs: if you separate stdout from stderr with something like
python testupload.py 2>stderr.log | tee stdout.log
you get only the bad failures in stderr.