Bugfix/ Model upload logs #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will defer to Paul to approve which versions we are supporting. I know previously the < was to prevent ultralytics from pushing breaking changes knowing we would support < Things have presumably settled down over there... |
|
Maybe we should pin to a specific version and have it match the version we use in the roboflow-model-conversion library. |
|
Hmm. version 8.0.20 did not work for me, and latest ultralytics did work. 8.0.20 is giving me this error: |
|
i'll pin it to the version in roboflow-model-conversion after I upgrade that ultralytics package |
paulguerrie
approved these changes
Jul 20, 2023
| @@ -593,14 +593,14 @@ def deploy(self, model_type: str, model_path: str) -> None: | |||
|
|
|||
| if self.public: | |||
| print( | |||
| f"View the status of your deployment at: {APP_URL}/{self.workspace}/{self.project}/deploy/{self.version}" | |||
| f"View the status of your deployment at: {APP_URL}/{self.workspace}/{self.project}/{self.version}" | |||
There was a problem hiding this comment.
Yeah, that's a big improvement!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Corrects logging for the model upload feature.
Previous logs asked for ultralytics version < 8.0.20, even though we require a greater version. And they point to the old URL path of
../deploy/..New logs point to correct path
Type of change
Please delete options that are not relevant.
How has this change been tested, please provide a testcase or example of how you tested the change?
Tested model upload with local package.
Any specific deployment considerations
None.