Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Clean up kinds #618

Merged
merged 7 commits into from
Sep 6, 2024
Merged

[WIP] Clean up kinds #618

merged 7 commits into from
Sep 6, 2024

Conversation

PawelPeczek-Roboflow
Copy link
Collaborator

Description

This PR is to address #608

Since last big update to EE we do not really need those legacy markers of Batch[X] and instead we shall just use X.

This PR is quite risky as this introduce breaking change, but I believe that it is better to do this step now rather than wait for this to become problematic in ecosystem. List of things that will break:

  • integration with UI, as we rely on kinds' names Batch[X] - easily to be fixed
  • some custom Python blocks pointing Batch[X] kinds (see changes in tests) - I believe we have near to zero instances of those in registered workflows, as this feature did not land in UI
  • existing open-source plugins and internal plugins (none I am aware of, but we can query FEs)

List of things that will not break:

  • workflows that are created w/o Dynamic Python Blocks (see no changes in integration tests)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How has this change been tested, please provide a testcase or example of how you tested the change?

YOUR_ANSWER

Any specific deployment considerations

For example, documentation changes, usability, usage/costs, secrets, etc.

Docs

  • Docs updated? What were the changes:

@PawelPeczek-Roboflow
Copy link
Collaborator Author

https://github.com/roboflow/roboflow/pull/4255 - the correlated PR

@PawelPeczek-Roboflow PawelPeczek-Roboflow merged commit d1329f3 into main Sep 6, 2024
58 checks passed
@PawelPeczek-Roboflow PawelPeczek-Roboflow deleted the fix/clean_up_kinds branch September 6, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants