simplify the FunctionalOptions by removing the Options struct

[robbyt]

No description provided.

[github-actions]

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

[Copilot]

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

machines/extism/compiler/options.go:114

• Directly comparing an atomic.Value with its zero value may be unreliable. Consider using a dedicated flag or checking if c.entryPointName.Load() returns nil for proper initialization.

if c.entryPointName == (atomic.Value{}) {

[Copilot]

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

machines/extism/compiler/compiler.go:137

• The removal of atomic.Value for entryPointName means that if this field may be updated concurrently after initialization, it could lead to data races. Consider using a concurrency-safe mechanism (such as sync/atomic or mutex protection) if concurrent modifications are expected.

func (c *Compiler) SetEntryPointName(fName string) { c.entryPointName = fName }

[sonarqubecloud]

Quality Gate failed

Failed conditions
12.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud