Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileTransfer - with Potential Fix: "Unable to send SI offer; the recipient doesn't have the required features." #1230

Open
dpasirst opened this issue Oct 14, 2023 · 0 comments

Comments

@dpasirst
Copy link

dpasirst commented Oct 14, 2023

XMPPFramework: 4.1.0
Running with eJabberd 23.04

Setup both sides with:

xmppIncommingFileTranser = XMPPIncomingFileTransfer()
xmppIncommingFileTranser.disableIBB = false
xmppIncommingFileTranser.disableSOCKS5 = false

fileTransfer = XMPPOutgoingFileTransfer(dispatchQueue: DispatchQueue.main)
fileTransfer.disableIBB = false
fileTransfer.disableSOCKS5 = false

Client 1 sends the transfer request to Client 2, Client 2 responds to Client 1 with:

<iq xmlns="jabber:client" lang="en" to="[email protected]/ccc" from="[email protected]/ddd" type="result" id="20AB1C3E-CEDD-4A7B-9512-28F50F2DFBDB">
  <query xmlns="http://jabber.org/protocol/disco#info">
  <identity category="client" type="ios-osx"></identity>
    <feature var="http://jabber.org/protocol/si"></feature>
    <feature var="http://jabber.org/protocol/si/profile/file-transfer"></feature>
    <feature var="http://jabber.org/protocol/bytestreams"></feature>
    <feature var="http://jabber.org/protocol/ibb"></feature>
  </query>
</iq>

XMPPFramework on Client 1: results in "Unable to send SI offer; the recipient doesn't have the required features."

I tracked it down to this file: XMPPFramework/Extensions/FileTransfer/XMPPOutgoingFileTransfer.m
LINE: 1048 NSXMLElement *query = [iq elementForName:@"query"];
The result of that line is query is NULL.
Changing that line to NSXMLElement *query = [iq childElement]; seems to fix the issue, but I'm not sure if it is specific enough to be a proper fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant