Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't fail when no vulnerabilities were detected #187

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Don't fail when no vulnerabilities were detected #187

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/nvd/report.clj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,9 +123,11 @@

(defn fail-build? [project]
(let [^Engine engine (:engine project)
highest-score (long (apply max 0 (scores engine)))
all-scores (scores engine)
highest-score (long (apply max 0 all-scores))
fail-threshold (long (get-in project [:nvd :fail-threshold] 0))]
(->
project
(assoc-in [:nvd :highest-score] highest-score)
(assoc :failed? (> highest-score fail-threshold)))))
(assoc :failed? (and (seq all-scores)
(> highest-score fail-threshold))))))
Comment on lines +132 to +133
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Consider adding a comment here to explain why (seq all-scores) is being checked. This makes the logic more explicit and easier to understand at a glance.

     (assoc :failed? (and (seq all-scores) ; Ensure there are scores before comparing
                          (> highest-score fail-threshold))))))

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does any actual person care for such a comment? Seems a bit silly to me given how small and obvious the function is.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, the comment doesn't even explain why we do this, it only re-states what we do. As the saying goes: The I in LLM stands for intelligence 😜