Feature/fix xpath matcher #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
roesslerj
commented
Dec 5, 2019
roesslerj
commented
- the code follows the Clean Code guidelines.
- the necessary tests are either created or updated.
- all status checks (Travis CI, SonarCloud, etc.) pass.
- your commit history is cleaned up.
- you updated the changelog.
- you updated necessary documentation within retest/docs.
|
Cool, this partly adresses retest/recheck-web#132 (see retest/recheck-web#132 (comment)). |
beatngu13
suggested changes
Dec 5, 2019
| @@ -26,7 +29,7 @@ public boolean test( final Element element ) { | |||
|
|
|||
| @Override | |||
| public String toString() { | |||
| return String.format( ElementXpathMatcherLoader.FORMAT, xpath ); | |||
| return String.format( ElementXpathMatcherLoader.FORMAT, "/" + xpath ); | |||
There was a problem hiding this comment.
The leading slash is correct for the absolute XPath, but this doesn't correspond to our internal representation I guess? Is this good?
There was a problem hiding this comment.
I guess we should think about changing our internal representation. But this is definitely a separate PR...
roesslerj
force-pushed
the
feature/fix-xpath-matcher
branch
from
07f2782 to
d6d3dd4
Compare
beatngu13
approved these changes
Dec 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.